Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: chrome/browser/autocomplete/history_quick_provider_unittest.cc

Issue 9030031: Move InMemoryURLIndex Caching Operations to FILE Thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Missed a private data swap. Try to fix update phase failure. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/history.cc » ('j') | chrome/browser/history/history.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/history_quick_provider_unittest.cc
===================================================================
--- chrome/browser/autocomplete/history_quick_provider_unittest.cc (revision 117518)
+++ chrome/browser/autocomplete/history_quick_provider_unittest.cc (working copy)
@@ -73,6 +73,8 @@
"Dogs & Cats & Mice & Other Animals", 1, 1, 0},
};
+// -----------------------------------------------------------------------------
+
class HistoryQuickProviderTest : public testing::Test,
public ACProviderListener {
public:
@@ -145,26 +147,21 @@
history::URLDatabase* db = history_service_->InMemoryDatabase();
ASSERT_TRUE(db != NULL);
- history::InMemoryURLIndex* index =
- new history::InMemoryURLIndex(FilePath());
- PrefService* prefs = profile_->GetPrefs();
- std::string languages(prefs->GetString(prefs::kAcceptLanguages));
- index->Init(db, languages);
+ history::InMemoryURLIndex* index = provider_->GetIndex();
for (size_t i = 0; i < arraysize(quick_test_db); ++i) {
const TestURLInfo& cur = quick_test_db[i];
const GURL current_url(cur.url);
Time visit_time = Time::Now() - TimeDelta::FromDays(cur.days_from_now);
history::URLRow url_info(current_url);
+ url_info.set_id(i + 5000);
url_info.set_title(UTF8ToUTF16(cur.title));
url_info.set_visit_count(cur.visit_count);
url_info.set_typed_count(cur.typed_count);
url_info.set_last_visit(visit_time);
url_info.set_hidden(false);
- index->UpdateURL(i, url_info);
+ index->UpdateURL(url_info);
}
-
- provider_->set_index(index);
}
HistoryQuickProviderTest::SetShouldContain::SetShouldContain(
« no previous file with comments | « no previous file | chrome/browser/history/history.cc » ('j') | chrome/browser/history/history.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698