Move InMemoryURLIndex Caching Operations to FILE Thread

chrome/browser/history/url_database.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/url_database.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 243 matching lines @@
   if (!enumerator->statement_) {
     NOTREACHED() << GetDB().GetErrorMessage();
     return false;
   }
   enumerator->initialized_ = true;
   return true;
 }
 
 bool URLDatabase::InitURLEnumeratorForSignificant(URLEnumerator* enumerator) {
   DCHECK(!enumerator->initialized_);
+  sql::Connection& db(GetDB());
+  if (!db.is_open())
+    return false;

[Peter Kasting, 2012/01/14 00:12:49]

We access GetDB() directly a lot in the rest of this file.  Is there a reason
this case should differ?

[mrossetti, 2012/03/03 05:05:56]

Done.

   std::string sql("SELECT ");
   sql.append(kURLRowFields);
   sql.append(" FROM urls WHERE last_visit_time >= ? OR visit_count >= ? OR "
              "typed_count >= ?");
-  enumerator->statement_.Assign(GetDB().GetUniqueStatement(sql.c_str()));
+  enumerator->statement_.Assign(db.GetUniqueStatement(sql.c_str()));
   if (!enumerator->statement_) {
-    NOTREACHED() << GetDB().GetErrorMessage();
+    NOTREACHED() << db.GetErrorMessage();
     return false;
   }
   enumerator->statement_.BindInt64(
       0, AutocompleteAgeThreshold().ToInternalValue());
   enumerator->statement_.BindInt(1, kLowQualityMatchVisitLimit);
   enumerator->statement_.BindInt(2, kLowQualityMatchTypedLimit);
   enumerator->initialized_ = true;
   return true;
 }
 
@@ skipping 295 matching lines @@
   return GetDB().Execute(sql.c_str());
 }
 
 bool URLDatabase::CreateMainURLIndex() {
   // Index over URLs so we can quickly look up based on URL.
   return GetDB().Execute(
       "CREATE INDEX IF NOT EXISTS urls_url_index ON urls (url)");
 }
 
 }  // namespace history