Issue 903003: Fix bug in assigned variables analysis....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 903003: Fix bug in assigned variables analysis.... (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in assigned variables analysis. Property stores were not visited correctly by the visitor. I fixed this issue by visiting property stores by visiting receiver and key directly (and not calling visit on the lhs property ast node) Committed: http://code.google.com/p/v8/source/detail?r=4117

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -9 lines)			Patch
	M	src/data-flow.cc	View	1	1 chunk	+13 lines, -9 lines	0 comments	Download
	A	test/mjsunit/regress/regress-643.js	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/903003/diff/1/3 File src/data-flow.cc (right): http://codereview.chromium.org/903003/diff/1/3#newcode1366 src/data-flow.cc:1366: Why so many blank lines in this function?

10 years, 9 months ago (2010-03-12 13:03:38 UTC) #2

fschneider

10 years, 9 months ago (2010-03-12 13:06:32 UTC) #3

http://codereview.chromium.org/903003/diff/1/3
File src/data-flow.cc (right):

http://codereview.chromium.org/903003/diff/1/3#newcode1366
src/data-flow.cc:1366: 
On 2010/03/12 13:03:38, Kevin Millikin wrote:
> Why so many blank lines in this function?

Done.

Expand Messages | Collapse Messages