chrome/browser/ui/gtk/location_bar_view_gtk.cc - Issue 9030029: GTK: A bunch more removal of deprecated raw GtkWidget access, focusing on GtkWidget->window

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 9030029: GTK: A bunch more removal of deprecated raw GtkWidget access, focusing on GtkWidget->window (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"	5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 1637 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1648	1648

1649 int tab_id = ExtensionTabUtil::GetTabId(contents);	1649 int tab_id = ExtensionTabUtil::GetTabId(contents);

1650 if (tab_id < 0)	1650 if (tab_id < 0)

1651 return FALSE;	1651 return FALSE;

1652	1652

1653 std::string badge_text = page_action_->GetBadgeText(tab_id);	1653 std::string badge_text = page_action_->GetBadgeText(tab_id);

1654 if (badge_text.empty())	1654 if (badge_text.empty())

1655 return FALSE;	1655 return FALSE;

1656	1656

1657 gfx::CanvasSkiaPaint canvas(event, false);	1657 gfx::CanvasSkiaPaint canvas(event, false);

1658 gfx::Rect bounding_rect(widget->allocation);	1658 GtkAllocation allocation;

1659 page_action_->PaintBadge(&canvas, bounding_rect, tab_id);	1659 gtk_widget_get_allocation(widget, &allocation);

	1660 page_action_->PaintBadge(&canvas, gfx::Rect(allocation), tab_id);

1660 return FALSE;	1661 return FALSE;

1661 }	1662 }

OLD	NEW

« no previous file with comments | « chrome/browser/ui/gtk/gtk_util.h ('k') | ui/gfx/gtk_preserve_window.cc » ('j') | ui/gfx/gtk_preserve_window.cc » ('J')