Issue 9030029: GTK: A bunch more removal of deprecated raw GtkWidget access, focusing on GtkWidget->window

Issue 9030029: GTK: A bunch more removal of deprecated raw GtkWidget access, focusing on GtkWidget->window (Closed)

Created:
8 years, 11 months ago by Elliot Glaysher

Modified:
8 years, 11 months ago

Reviewers:
tony, Ben Goodger (Google), sky

CC:
chromium-reviews, asanka, pam+watch_chromium.org, darin-cc_chromium.org, Randy Smith (Not in Mondays)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: A bunch more removal of deprecated raw GtkWidget access, focusing on GtkWidget->window BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116430

Patch Set 2 : tony nits #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -38 lines)			Patch
M	chrome/browser/ui/gtk/avatar_menu_item_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_item_gtk.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_chrome_link_button.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_custom_menu_item.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/gfx/gtk_preserve_window.cc	View	1	6 chunks	+28 lines, -20 lines	0 comments	Download
M	webkit/plugins/npapi/gtk_plugin_container_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/9030029/diff/1/ui/gfx/gtk_preserve_window.cc File ui/gfx/gtk_preserve_window.cc (right): http://codereview.chromium.org/9030029/diff/1/ui/gfx/gtk_preserve_window.cc#newcode66 ui/gfx/gtk_preserve_window.cc:66: GdkWindow* window = gtk_widget_get_window(widget); Nit: Maybe call this ...

8 years, 11 months ago (2012-01-04 19:08:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9030029/12

8 years, 11 months ago (2012-01-04 19:16:56 UTC) #3

commit-bot: I haz the power

Presubmit check for 9030029-12 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 11 months ago (2012-01-04 19:17:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9030029/12

8 years, 11 months ago (2012-01-04 23:40:35 UTC) #8

Change committed as 116430

Expand Messages | Collapse Messages