Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 9030023: Fix prctl ERROR messages on Linux debug builds. (Closed)

Created:
8 years, 11 months ago by Rick Byers
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix prctl ERROR messages on Linux debug builds. In sandboxed processes, prctl(PR_SET_NAME) will fail with EPERM. Don't generate DLOGs for that case - just silently ignore failures like release builds do. This is just a debugging tool, working just in the browser process is good enough for now. BUG=109124 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/threading/platform_thread_posix.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
Evan, can you please review this tweak to the thread name code that we discussed? ...
8 years, 11 months ago (2012-01-04 17:22:31 UTC) #1
Evan Martin
LGTM
8 years, 11 months ago (2012-01-04 17:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/9030023/1
8 years, 11 months ago (2012-01-04 17:39:19 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-04 19:07:55 UTC) #4
Change committed as 116351

Powered by Google App Engine
This is Rietveld 408576698