Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 9030010: Move most of the remaining users of WebContentsObserver::tab_contents() to use web_contents(). (Closed)

Created:
8 years, 12 months ago by jam
Modified:
8 years, 12 months ago
Reviewers:
Jói
CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, stuartmorgan+watch_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, kkania, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., ajwong+watch_chromium.org, robertshield, mmenke
Visibility:
Public.

Description

Move most of the remaining users of WebContentsObserver::tab_contents() to use web_contents(). BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115800

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -243 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 14 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/tabs/tab_finder.h View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/translate/translate_manager.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/sad_tab_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/snapshot_tab_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 4 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sad_tab_view.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 8 chunks +12 lines, -10 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/download/save_package.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M content/browser/intents/intent_injector.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/intents/web_intents_dispatcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 12 months ago (2011-12-26 18:09:41 UTC) #1
Jói
8 years, 12 months ago (2011-12-27 11:37:26 UTC) #2
LGTM

On Mon, Dec 26, 2011 at 6:09 PM,  <jam@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Move most of the remaining users of WebContentsObserver::tab_contents() to
> use
> web_contents().
>
> BUG=98716
> TBR=joi
>
> Please review this at http://codereview.chromium.org/9030010/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/automation/automation_provider_observers.h
>  M     chrome/browser/automation/automation_provider_observers.cc
>  M     chrome/browser/automation/testing_automation_provider.cc
>  M     chrome/browser/extensions/extension_tabs_module.cc
>  M     chrome/browser/extensions/extension_webnavigation_api.cc
>  M     chrome/browser/plugin_observer.cc
>  M     chrome/browser/prerender/prerender_contents.h
>  M     chrome/browser/prerender/prerender_contents.cc
>  M     chrome/browser/safe_browsing/browser_feature_extractor.h
>  M     chrome/browser/safe_browsing/browser_feature_extractor.cc
>  M     chrome/browser/safe_browsing/client_side_detection_host.h
>  M     chrome/browser/safe_browsing/client_side_detection_host.cc
>  M     chrome/browser/safe_browsing/malware_details.h
>  M     chrome/browser/safe_browsing/malware_details.cc
>  M     chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
>  M     chrome/browser/tab_contents/thumbnail_generator.h
>  M     chrome/browser/tab_contents/thumbnail_generator.cc
>  M     chrome/browser/tabs/tab_finder.h
>  M     chrome/browser/tabs/tab_finder.cc
>  M     chrome/browser/translate/translate_manager.h
>  M     chrome/browser/translate/translate_manager.cc
>  M     chrome/browser/translate/translate_tab_helper.cc
>  M     chrome/browser/ui/alternate_error_tab_observer.h
>  M     chrome/browser/ui/alternate_error_tab_observer.cc
>  M     chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
>  M     chrome/browser/ui/browser_browsertest.cc
>  M     chrome/browser/ui/constrained_window_tab_helper.cc
>  M     chrome/browser/ui/find_bar/find_bar_controller.cc
>  M     chrome/browser/ui/find_bar/find_tab_helper.cc
>  M     chrome/browser/ui/prefs/prefs_tab_helper.h
>  M     chrome/browser/ui/prefs/prefs_tab_helper.cc
>  M     chrome/browser/ui/sad_tab_observer.cc
>  M     chrome/browser/ui/snapshot_tab_helper.cc
>  M     chrome/browser/ui/tab_contents/core_tab_helper.h
>  M     chrome/browser/ui/tab_contents/core_tab_helper.cc
>  M     chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
>  M     chrome/browser/ui/views/find_bar_host_interactive_uitest.cc
>  M     chrome/browser/ui/views/sad_tab_view.h
>  M     chrome/browser/ui/views/sad_tab_view.cc
>  M     chrome/common/chrome_notification_types.h
>  M     chrome/test/base/ui_test_utils.cc
>  M     content/browser/download/save_package.cc
>  M     content/browser/intents/intent_injector.cc
>  M     content/browser/intents/web_intents_dispatcher_impl.cc
>  M     content/browser/renderer_host/render_view_host_delegate.h
>  M     content/browser/renderer_host/render_view_host_delegate.cc
>  M     content/browser/renderer_host/resource_dispatcher_host.cc
>  M     content/browser/ssl/ssl_manager.cc
>  M     content/browser/tab_contents/tab_contents.h
>  M     content/browser/tab_contents/tab_contents.cc
>  M     content/public/browser/notification_types.h
>
>

Powered by Google App Engine
This is Rietveld 408576698