Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 9030001: Move paint aggregator and the completion callback factory. (Closed)

Created:
9 years ago by brettw
Modified:
8 years, 10 months ago
Reviewers:
noelallen1, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Move paint aggregator and the completion callback factory. Move paint aggregator and the completion callback factory to the ppapi/helpers directory since they're not strictly wrappers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116281

Patch Set 1 #

Patch Set 2 : Fix some things #

Patch Set 3 : Fix DEPS #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -2320 lines) Patch
M gpu/demos/framework/pepper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/cpp/completion_callback.h View 2 chunks +1 line, -550 lines 0 comments Download
D ppapi/cpp/non_thread_safe_ref_count.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ppapi/cpp/paint_aggregator.h View 1 chunk +0 lines, -174 lines 0 comments Download
D ppapi/cpp/paint_aggregator.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D ppapi/cpp/paint_manager.h View 1 chunk +0 lines, -297 lines 0 comments Download
D ppapi/cpp/paint_manager.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M ppapi/example/example.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/examples/2d/paint_manager_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/examples/2d/scroll.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/examples/audio_input/audio_input.cc View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/examples/file_chooser/file_chooser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/examples/gles2/gles2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/examples/mouse_lock/mouse_lock.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ppapi/examples/url_loader/streaming.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/examples/video_capture/video_capture.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/file_downloader.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_audio_input_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_audio_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_broker_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_io_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_flash_menu_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_net_connector_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_flash.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash.cc View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M ppapi/tests/test_paint_aggregator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_transport.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/testing_instance.h View 1 1 chunk +1 line, -1 line 0 comments Download
A ppapi/utility/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A ppapi/utility/README.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + ppapi/utility/completion_callback_factory.h View 1 chunk +564 lines, -710 lines 0 comments Download
A + ppapi/utility/graphics/paint_aggregator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ppapi/utility/graphics/paint_aggregator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ppapi/utility/graphics/paint_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ppapi/utility/graphics/paint_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ppapi/utility/non_thread_safe_ref_count.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/pepper_transport_socket_adapter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
We'll have to update some SDK stuff to account for this change.
9 years ago (2011-12-22 18:55:20 UTC) #1
noelallen1
One nit, otherwise LGTM http://codereview.chromium.org/9030001/diff/15002/ppapi/tests/test_flash.cc File ppapi/tests/test_flash.cc (right): http://codereview.chromium.org/9030001/diff/15002/ppapi/tests/test_flash.cc#newcode9 ppapi/tests/test_flash.cc:9: #include "ppapi/cpp/completion_callback.h" completion_callback_factory? I think ...
8 years, 11 months ago (2012-01-03 23:44:34 UTC) #2
brettw
TBR=wez for remoting
8 years, 11 months ago (2012-01-04 04:26:43 UTC) #3
Wez
(Re-opening, since it looks like this got reverted)
8 years, 11 months ago (2012-01-04 11:32:06 UTC) #4
Wez
8 years, 11 months ago (2012-01-04 11:34:34 UTC) #5
LGTM for remoting/, FWIW.

Powered by Google App Engine
This is Rietveld 408576698