Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: vm/dart_api_impl.cc

Issue 9027025: In CheckIsolate process only if we have any unfinalized classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 2724)
+++ vm/dart_api_impl.cc (working copy)
@@ -53,9 +53,12 @@
// Return error if isolate is in an inconsistent state.
// Return NULL when no error condition exists.
const char* CheckIsolateState(Isolate* isolate, bool generating_snapshot) {
- bool success = (generating_snapshot) ?
- ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
- ClassFinalizer::FinalizePendingClasses();
+ bool success = true;
+ if (!ClassFinalizer::AllClassesFinalized()) {
+ success = (generating_snapshot) ?
+ ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
+ ClassFinalizer::FinalizePendingClasses();
+ }
if (success && !generating_snapshot) {
success = isolate->object_store()->PreallocateObjects();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698