aura: Allow fullscreen RWHVAs (i.e. Flash) to be focused.

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/logging.h"
 #include "content/browser/renderer_host/backing_store_skia.h"
 #include "content/browser/renderer_host/render_widget_host.h"
 #include "content/browser/renderer_host/web_input_event_aura.h"
@@ skipping 568 matching lines @@
   delete this;
 }
 
 void RenderWidgetHostViewAura::OnWindowVisibilityChanged(bool visible) {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewAura, aura::client::ActivationDelegate implementation:
 
 bool RenderWidgetHostViewAura::ShouldActivate(aura::Event* event) {
-  return false;
+  return is_fullscreen_;

[Daniel Erat, 2011/12/22 19:33:19]

I suspect that the desired approach is to leave this at false and override
ShouldActivate() (e.g. views::NativeWidgetAura::can_activate_), but looking at
the call stack when this gets created by fullscreening a Flash object, I'm
unsure that that's an option here:

#0  RenderWidgetHostViewAura::RenderWidgetHostViewAura (this=0xf89f8000,
host=0xfa684100) at
../../content/browser/renderer_host/render_widget_host_view_aura.cc:100
#1  0xf66c6fe4 in chrome::ChromeContentBrowserClient::CreateViewForWidget
(this=0xf807c5e4, widget=0xfa684100) at
../../chrome/browser/chrome_content_browser_client.cc:300
#2  0xf69c7b3c in RenderViewHostDelegateViewHelper::CreateNewFullscreenWidget
(this=0xfb004528, route_id=2, process=0xfc603500) at
../../chrome/browser/tab_contents/render_view_host_delegate_helper.cc:211
#3  0xf6a89f92 in TabContentsViewViews::CreateNewFullscreenWidget
(this=0xfb004480, route_id=2) at
../../chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc:314
#4  0xf4bab184 in RenderViewHost::CreateNewFullscreenWidget (this=0xf817d000,
route_id=2) at ../../content/browser/renderer_host/render_view_host.cc:796
#5  0xf4bba214 in RenderWidgetHelper::OnCreateFullscreenWidgetOnUI
(this=0xfb0f7480, opener_id=1, route_id=2) at
../../content/browser/renderer_host/render_widget_helper.cc:278

Let me know if there's a better approach that I'm missing.

 }
 
 void RenderWidgetHostViewAura::OnActivated() {
 }
 
 void RenderWidgetHostViewAura::OnLostActive() {
 }
 
 #if defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 32 matching lines @@
 // static
 void RenderWidgetHostView::GetDefaultScreenInfo(
     WebKit::WebScreenInfo* results) {
   const gfx::Size size = gfx::Screen::GetPrimaryMonitorSize();
   results->rect = WebKit::WebRect(0, 0, size.width(), size.height());
   results->availableRect = results->rect;
   // TODO(derat): Don't hardcode this?
   results->depth = 24;
   results->depthPerComponent = 8;
 }