Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: webkit/plugins/ppapi/ppb_websocket_impl.h

Issue 9026007: WebSocket Pepper API: WebArrayBuffer support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_websocket.cc ('k') | webkit/plugins/ppapi/ppb_websocket_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_websocket_impl.h
diff --git a/webkit/plugins/ppapi/ppb_websocket_impl.h b/webkit/plugins/ppapi/ppb_websocket_impl.h
index 7ac9acd0c59c371cfc205970302ad490fd7ed7fb..7dd4520cb80260e5b7b7f07656dc5897d40d7471 100644
--- a/webkit/plugins/ppapi/ppb_websocket_impl.h
+++ b/webkit/plugins/ppapi/ppb_websocket_impl.h
@@ -9,6 +9,7 @@
#include "base/memory/scoped_ptr.h"
#include "ppapi/shared_impl/resource.h"
+#include "ppapi/shared_impl/var.h"
#include "ppapi/thunk/ppb_websocket_api.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebSocketClient.h"
@@ -63,6 +64,7 @@ class PPB_WebSocket_Impl : public ::ppapi::Resource,
virtual void didConnect();
virtual void didReceiveMessage(const WebKit::WebString& message);
virtual void didReceiveBinaryData(const WebKit::WebData& binaryData);
+ virtual void didReceiveArrayBuffer(const WebKit::WebArrayBuffer& binaryData);
virtual void didReceiveMessageError();
virtual void didUpdateBufferedAmount(unsigned long buffered_amount);
virtual void didStartClosingHandshake();
@@ -82,8 +84,7 @@ class PPB_WebSocket_Impl : public ::ppapi::Resource,
PP_CompletionCallback receive_callback_;
PP_Var* receive_callback_var_;
bool wait_for_receive_;
- // TODO(toyoshim): Use std::queue<Var> when it supports binary.
- std::queue<PP_Var> received_messages_;
+ std::queue< ::ppapi::Var*> received_messages_;
dmichael (off chromium) 2012/01/13 17:36:14 Should this be scoped_refptr< ::ppapi::Var>?
Takashi Toyoshima 2012/01/17 10:14:59 Done.
PP_CompletionCallback close_callback_;
uint16_t close_code_;
« no previous file with comments | « ppapi/tests/test_websocket.cc ('k') | webkit/plugins/ppapi/ppb_websocket_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698