Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: samples/total/src/Dartc.dart

Issue 9024008: Change the process API to be completely asynchronous. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Presubmit fixes Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/total/src/Dartc.dart
diff --git a/samples/total/src/Dartc.dart b/samples/total/src/Dartc.dart
index c8dedc9b67790d3f77dd19a7d951db17cd8c0747..231ac06a9ca910a9e610f4eaffefaa27b5cbc6a4 100644
--- a/samples/total/src/Dartc.dart
+++ b/samples/total/src/Dartc.dart
@@ -46,15 +46,12 @@ class Dartc {
}
args.add(scriptName);
- Process compiler = new Process(DARTC_EXEC_PATH, args);
-
+ Process compiler = new Process.start(DARTC_EXEC_PATH, args);
StringBuffer messages = new StringBuffer();
compiler.exitHandler = (int status) {
- compiler.close();
- callback(status, messages.toString());
- };
-
- compiler.start();
+ compiler.close();
+ callback(status, messages.toString());
+ };
compiler.stdout.dataHandler = () => _readAll(compiler.stdout, messages);
compiler.stderr.dataHandler = () => _readAll(compiler.stderr, messages);

Powered by Google App Engine
This is Rietveld 408576698