Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9023007: Determine page size at runtime on posix platforms. (Closed)

Created:
9 years ago by kalmard
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Determine page size at runtime on posix platforms. r10143 (f59d71a5) added OS:CommitPageSize which returns a constant (4k). This broke some tests on devices using different page sizes. BUG= TEST=

Patch Set 1 #

Patch Set 2 : Rebased on r10334. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/platform-posix.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kalmard
9 years ago (2011-12-22 16:37:18 UTC) #1
kalmard
Rebased on r10334.
8 years, 11 months ago (2012-01-05 09:07:19 UTC) #2
Erik Corry
LGTM, will land.
8 years, 11 months ago (2012-01-05 10:05:34 UTC) #3
kalmard
8 years, 11 months ago (2012-01-19 12:48:57 UTC) #4
Landed in r10337. Closing.

Powered by Google App Engine
This is Rietveld 408576698