Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: removed one redundant smi-check Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/hydrogen.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1911 matching lines...) Expand 10 before | Expand all | Expand 10 after
1922 ASSERT(instr->object()->representation().IsTagged()); 1922 ASSERT(instr->object()->representation().IsTagged());
1923 ASSERT(instr->key()->representation().IsInteger32()); 1923 ASSERT(instr->key()->representation().IsInteger32());
1924 1924
1925 LOperand* obj = UseTempRegister(instr->object()); 1925 LOperand* obj = UseTempRegister(instr->object());
1926 LOperand* val = needs_write_barrier 1926 LOperand* val = needs_write_barrier
1927 ? UseTempRegister(instr->value()) 1927 ? UseTempRegister(instr->value())
1928 : UseRegisterAtStart(instr->value()); 1928 : UseRegisterAtStart(instr->value());
1929 LOperand* key = needs_write_barrier 1929 LOperand* key = needs_write_barrier
1930 ? UseTempRegister(instr->key()) 1930 ? UseTempRegister(instr->key())
1931 : UseRegisterOrConstantAtStart(instr->key()); 1931 : UseRegisterOrConstantAtStart(instr->key());
1932 1932 return new LStoreKeyedFastElement(obj, key, val);
1933 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val));
1934 } 1933 }
1935 1934
1936 1935
1937 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement( 1936 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
1938 HStoreKeyedFastDoubleElement* instr) { 1937 HStoreKeyedFastDoubleElement* instr) {
1939 ASSERT(instr->value()->representation().IsDouble()); 1938 ASSERT(instr->value()->representation().IsDouble());
1940 ASSERT(instr->elements()->representation().IsTagged()); 1939 ASSERT(instr->elements()->representation().IsTagged());
1941 ASSERT(instr->key()->representation().IsInteger32()); 1940 ASSERT(instr->key()->representation().IsInteger32());
1942 1941
1943 LOperand* elements = UseRegisterAtStart(instr->elements()); 1942 LOperand* elements = UseRegisterAtStart(instr->elements());
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
2239 LOperand* key = UseOrConstantAtStart(instr->key()); 2238 LOperand* key = UseOrConstantAtStart(instr->key());
2240 LOperand* object = UseOrConstantAtStart(instr->object()); 2239 LOperand* object = UseOrConstantAtStart(instr->object());
2241 LIn* result = new LIn(key, object); 2240 LIn* result = new LIn(key, object);
2242 return MarkAsCall(DefineFixed(result, rax), instr); 2241 return MarkAsCall(DefineFixed(result, rax), instr);
2243 } 2242 }
2244 2243
2245 2244
2246 } } // namespace v8::internal 2245 } } // namespace v8::internal
2247 2246
2248 #endif // V8_TARGET_ARCH_X64 2247 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/hydrogen.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698