Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: removed one redundant smi-check Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1923 matching lines...) Expand 10 before | Expand all | Expand 10 after
1934 ASSERT(instr->object()->representation().IsTagged()); 1934 ASSERT(instr->object()->representation().IsTagged());
1935 ASSERT(instr->key()->representation().IsInteger32()); 1935 ASSERT(instr->key()->representation().IsInteger32());
1936 1936
1937 LOperand* obj = UseTempRegister(instr->object()); 1937 LOperand* obj = UseTempRegister(instr->object());
1938 LOperand* val = needs_write_barrier 1938 LOperand* val = needs_write_barrier
1939 ? UseTempRegister(instr->value()) 1939 ? UseTempRegister(instr->value())
1940 : UseRegisterAtStart(instr->value()); 1940 : UseRegisterAtStart(instr->value());
1941 LOperand* key = needs_write_barrier 1941 LOperand* key = needs_write_barrier
1942 ? UseTempRegister(instr->key()) 1942 ? UseTempRegister(instr->key())
1943 : UseRegisterOrConstantAtStart(instr->key()); 1943 : UseRegisterOrConstantAtStart(instr->key());
1944 1944 return new LStoreKeyedFastElement(obj, key, val);
1945 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val));
1946 } 1945 }
1947 1946
1948 1947
1949 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement( 1948 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
1950 HStoreKeyedFastDoubleElement* instr) { 1949 HStoreKeyedFastDoubleElement* instr) {
1951 ASSERT(instr->value()->representation().IsDouble()); 1950 ASSERT(instr->value()->representation().IsDouble());
1952 ASSERT(instr->elements()->representation().IsTagged()); 1951 ASSERT(instr->elements()->representation().IsTagged());
1953 ASSERT(instr->key()->representation().IsInteger32()); 1952 ASSERT(instr->key()->representation().IsInteger32());
1954 1953
1955 LOperand* elements = UseRegisterAtStart(instr->elements()); 1954 LOperand* elements = UseRegisterAtStart(instr->elements());
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
2242 2241
2243 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2242 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2244 LOperand* key = UseRegisterAtStart(instr->key()); 2243 LOperand* key = UseRegisterAtStart(instr->key());
2245 LOperand* object = UseRegisterAtStart(instr->object()); 2244 LOperand* object = UseRegisterAtStart(instr->object());
2246 LIn* result = new LIn(key, object); 2245 LIn* result = new LIn(key, object);
2247 return MarkAsCall(DefineFixed(result, v0), instr); 2246 return MarkAsCall(DefineFixed(result, v0), instr);
2248 } 2247 }
2249 2248
2250 2249
2251 } } // namespace v8::internal 2250 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698