Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 9023006: Remove unnecessary environment from LStoreKeyedFastElements. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: removed one redundant smi-check Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1920 matching lines...) Expand 10 before | Expand all | Expand 10 after
1931 ASSERT(instr->object()->representation().IsTagged()); 1931 ASSERT(instr->object()->representation().IsTagged());
1932 ASSERT(instr->key()->representation().IsInteger32()); 1932 ASSERT(instr->key()->representation().IsInteger32());
1933 1933
1934 LOperand* obj = UseTempRegister(instr->object()); 1934 LOperand* obj = UseTempRegister(instr->object());
1935 LOperand* val = needs_write_barrier 1935 LOperand* val = needs_write_barrier
1936 ? UseTempRegister(instr->value()) 1936 ? UseTempRegister(instr->value())
1937 : UseRegisterAtStart(instr->value()); 1937 : UseRegisterAtStart(instr->value());
1938 LOperand* key = needs_write_barrier 1938 LOperand* key = needs_write_barrier
1939 ? UseTempRegister(instr->key()) 1939 ? UseTempRegister(instr->key())
1940 : UseRegisterOrConstantAtStart(instr->key()); 1940 : UseRegisterOrConstantAtStart(instr->key());
1941 1941 return new LStoreKeyedFastElement(obj, key, val);
1942 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val));
1943 } 1942 }
1944 1943
1945 1944
1946 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement( 1945 LInstruction* LChunkBuilder::DoStoreKeyedFastDoubleElement(
1947 HStoreKeyedFastDoubleElement* instr) { 1946 HStoreKeyedFastDoubleElement* instr) {
1948 ASSERT(instr->value()->representation().IsDouble()); 1947 ASSERT(instr->value()->representation().IsDouble());
1949 ASSERT(instr->elements()->representation().IsTagged()); 1948 ASSERT(instr->elements()->representation().IsTagged());
1950 ASSERT(instr->key()->representation().IsInteger32()); 1949 ASSERT(instr->key()->representation().IsInteger32());
1951 1950
1952 LOperand* elements = UseRegisterAtStart(instr->elements()); 1951 LOperand* elements = UseRegisterAtStart(instr->elements());
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
2239 2238
2240 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2239 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2241 LOperand* key = UseRegisterAtStart(instr->key()); 2240 LOperand* key = UseRegisterAtStart(instr->key());
2242 LOperand* object = UseRegisterAtStart(instr->object()); 2241 LOperand* object = UseRegisterAtStart(instr->object());
2243 LIn* result = new LIn(key, object); 2242 LIn* result = new LIn(key, object);
2244 return MarkAsCall(DefineFixed(result, r0), instr); 2243 return MarkAsCall(DefineFixed(result, r0), instr);
2245 } 2244 }
2246 2245
2247 2246
2248 } } // namespace v8::internal 2247 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698