Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc

Issue 9022021: Proxy PPB_ArrayBuffer_Dev, make them work over Messaging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add testing for multiple sizes of array. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc
index d2d35e599fa76632bbbd5f05f65e7c100aff8a3e..96de74acaa732f37d2f536e187079f8e17bfcd4b 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_messaging_rpc_server.cc
@@ -27,13 +27,16 @@ void PpbMessagingRpcServer::PPB_Messaging_PostMessage(
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
PP_Var message;
- if (!DeserializeTo(message_bytes, message_size, 1, &message))
+ if (!DeserializeTo(message_bytes, message_size, 1, &message)) {
+ DebugPrintf("PPB_Messaging::HandleMessage, DeserializeTo failed!\n");
return;
+ }
PPBMessagingInterface()->PostMessage(instance, message);
- // In the case of a string, DeserializeTo creates a PP_Var with a reference-
- // count of 1. We must release the var, or it will stay in the browser's map.
+ // In the case of ref-counted types, DeserializeTo creates a PP_Var with a ref
+ // erence-count of 1. We must release the var, or it will stay in the
+ // browser's map.
PPBVarInterface()->Release(message);
DebugPrintf("PPB_Messaging::PostMessage: instance=%"NACL_PRIu32"\n",

Powered by Google App Engine
This is Rietveld 408576698