Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9021040: Roll breakpad to r897 to eliminate UnspecifiedStackSignature crash dumps. (Closed)

Created:
9 years ago by Sigurður Ásgeirsson
Modified:
9 years ago
Reviewers:
Mark Mentovai, Ben Chan
CC:
chromium-reviews
Visibility:
Public.

Description

Roll breakpad to r897 to eliminate UnspecifiedStackSignature crash dumps. R=mark@chromium.org,benchan@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115614

Patch Set 1 #

Patch Set 2 : Fix GYP config for Linux. #

Patch Set 3 : Work around a link failure. #

Patch Set 4 : Another attempt to fix linux breakpad build. #

Patch Set 5 : Add safe_readlink files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 2 3 4 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sigurður Ásgeirsson
PTAL
9 years ago (2011-12-21 22:18:07 UTC) #1
Mark Mentovai
LGTM
9 years ago (2011-12-21 22:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/9021040/1
9 years ago (2011-12-21 22:24:46 UTC) #3
commit-bot: I haz the power
Try job failure for 9021040-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-21 23:06:24 UTC) #4
Sigurður Ásgeirsson
Added GYP config to compile new dependency for Linux. PTAL?
9 years ago (2011-12-22 01:31:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/9021040/8
9 years ago (2011-12-22 02:10:50 UTC) #6
commit-bot: I haz the power
Try job failure for 9021040-8 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years ago (2011-12-22 03:30:45 UTC) #7
Sigurður Ásgeirsson
Ben, please check this out, as it appears your change introduced new deps for a ...
9 years ago (2011-12-22 14:19:48 UTC) #8
Ben Chan
On 2011/12/22 14:19:48, Ruðrugis wrote: > Ben, please check this out, as it appears your ...
9 years ago (2011-12-22 16:58:14 UTC) #9
Ben Chan
On 2011/12/22 16:58:14, Ben Chan wrote: > On 2011/12/22 14:19:48, Ruðrugis wrote: > > Ben, ...
9 years ago (2011-12-22 18:00:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/9021040/14002
9 years ago (2011-12-22 18:04:18 UTC) #11
commit-bot: I haz the power
9 years ago (2011-12-22 21:54:20 UTC) #12
Change committed as 115614

Powered by Google App Engine
This is Rietveld 408576698