Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array....

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 56 matching lines @@
   class Manifest {
    public:
     // Purposely not marked explicit for convenience. The vast majority of
     // callers pass string literal.
     Manifest(const char* name)
         : name_(name), manifest_(NULL) {
     }
     Manifest(DictionaryValue* manifest, const char* name)
         : name_(name), manifest_(manifest) {
     }
+    Manifest(const Manifest& m) {
+      // C++98 requires the copy constructor for a type to be visiable if you
+      // take a const-ref of a temporary for that type.  Since Manifest
+      // contains a scoped_ptr, its implicit copy constructor is declared
+      // Manifest(Manifest&) according to spec 12.8.5.  This breaks the first
+      // requirement and thus you cannot use it with LoadAndExpectError() or
+      // LoadAndExpectSuccess() easily.
+      //
+      // To get around this spec pedantry, we declare the copy constructor
+      // explicitly.  It will never get invoked.
+      NOTREACHED();
+    }
+
 
     const std::string& name() const { return name_; }
 
     DictionaryValue* GetManifest(std::string* error) const {
       if (manifest_)
         return manifest_;
 
       manifest_ = LoadManifestFile(name_, error);
       manifest_holder_.reset(manifest_);
       return manifest_;
@@ skipping 873 matching lines @@
   // This guy is identical to the previous but doesn't ask for any
   // platform-app-only permissions. We should be able to load him and ask
   // questions about his permissions.
   scoped_refptr<Extension> extension(
       LoadAndExpectSuccess("not_platform_app.json"));
   ExtensionAPIPermissionSet apis = extension->GetActivePermissions()->apis();
   for (ExtensionAPIPermissionSet::const_iterator i = apis.begin();
        i != apis.end(); ++i)
     EXPECT_NE(platform_app, info->GetByID(*i)->type_restrictions());
 }