Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: vm/code_generator_ia32.cc

Issue 9021025: Check all cases with "__ movl(FieldAddress" and converted them to StoreIntoObject where appropriate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/assembler_macros_ia32.cc ('k') | vm/intrinsifier_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/code_generator_ia32.cc
===================================================================
--- vm/code_generator_ia32.cc (revision 2709)
+++ vm/code_generator_ia32.cc (working copy)
@@ -298,6 +298,7 @@
__ cmpl(EBX, Immediate(FLAG_optimization_invocation_threshold));
__ j(GREATER, &StubCode::OptimizeInvokedFunctionLabel());
}
+ // EBX is an integer value (not an object).
__ movl(FieldAddress(EAX, Function::invocation_counter_offset()), EBX);
}
}
@@ -402,8 +403,10 @@
__ movl(scratch, FieldAddress(base, Context::parent_offset()));
base = scratch;
}
- __ movl(FieldAddress(base, Context::variable_offset(variable.index())),
- src);
+ __ StoreIntoObject(
+ base,
+ FieldAddress(base, Context::variable_offset(variable.index())),
+ src);
} else {
// The variable lives in the current stack frame.
__ movl(Address(EBP, variable.index() * kWordSize), src);
@@ -935,7 +938,7 @@
GenerateCall(node_sequence->token_index(), &label);
// Chain the new context in EAX to its parent in CTX.
- __ movl(FieldAddress(EAX, Context::parent_offset()), CTX);
+ __ StoreIntoObject(EAX, FieldAddress(EAX, Context::parent_offset()), CTX);
// Set new context as current context.
__ movl(CTX, EAX);
state()->set_context_level(scope->context_level());
@@ -1907,6 +1910,7 @@
__ cmpl(EBX, Immediate(FLAG_optimization_invocation_threshold));
__ j(GREATER, &done);
}
+ // EBX is an integer value (not an object).
__ movl(FieldAddress(EAX, Function::invocation_counter_offset()), EBX);
__ Bind(&done);
}
« no previous file with comments | « vm/assembler_macros_ia32.cc ('k') | vm/intrinsifier_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698