Optimize indexed store for growable array (intrinsification and inlined optimized).

runtime/vm/opt_code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/opt_code_generator.h"
 
 #include "vm/assembler_macros.h"
@@ skipping 2342 matching lines @@
     }
     TraceOpt(node, kMessage);
     return;
   }
 
   const String& growable_object_array_class_name = String::Handle(
       String::NewSymbol(kGrowableArrayClassName));
   const Class& growable_array_class = Class::ZoneHandle(
       Library::Handle(Library::CoreImplLibrary()).
           LookupClass(growable_object_array_class_name));
+  ASSERT(!growable_array_class.IsNull());
   if (AtIdNodeHasOnlyClass(node, node->id(), growable_array_class)) {
     const String& growable_array_length_field_name =
         String::Handle(String::NewSymbol(kGrowableArrayLengthFieldName));
     const String& growable_array_array_field_name =
         String::Handle(String::NewSymbol(kGrowableArrayArrayFieldName));
     intptr_t length_offset = GetFieldOffset(growable_array_class,
                                             growable_array_length_field_name);
     intptr_t array_offset = GetFieldOffset(growable_array_class,
                                            growable_array_array_field_name);
     VisitLoadTwo(node->array(), node->index_expr(), EDX, EAX);
@@ skipping 38 matching lines @@
   const Class& object_array_class =
       Class::ZoneHandle(object_store->array_class());
   const ICData& ic_data = node->ICDataAtId(node->id());
   if (ic_data.NumberOfChecks() == 0) {
     VisitLoadTwo(node->index_expr(), node->value(), EBX, ECX);
     DeoptimizationBlob* deopt_blob =
         AddDeoptimizationBlob(node, EBX, ECX, kDeoptNoTypeFeedback);
     __ jmp(deopt_blob->label());
     return;
   }
+
   if (AtIdNodeHasOnlyClass(node, node->id(), object_array_class)) {
     VisitLoadTwo(node->index_expr(), node->value(), EBX, ECX);
     DeoptimizationBlob* deopt_blob =
         AddDeoptimizationBlob(node, EAX, EBX, ECX, kDeoptStoreIndexed);
     __ popl(EAX);  // array.
     // ECX: value, EBX:index, EAX: array.
-    // Check type of array.
+    // Check class of array.
     __ testl(EAX, Immediate(kSmiTagMask));
     __ j(ZERO, deopt_blob->label());  // Array is smi -> deopt.
     __ movl(EDX, FieldAddress(EAX, Object::class_offset()));
     __ CompareObject(EDX, object_array_class);
     __ j(NOT_EQUAL, deopt_blob->label());  // Not ObjectArray -> deopt.
-    // Check type of index.
+    // Check class of index.
     __ testl(EBX, Immediate(kSmiTagMask));
     __ j(NOT_ZERO, deopt_blob->label());  // Index not Smi -> deopt.
     // Range check.
     __ cmpl(EBX, FieldAddress(EAX, Array::length_offset()));
     __ j(ABOVE_EQUAL, deopt_blob->label());  // Range error -> deopt.
     ASSERT(kSmiTagShift == 1);
     __ StoreIntoObject(EAX,
                        FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)),
                        ECX);
     if (CodeGenerator::IsResultNeeded(node)) {
       __ pushl(ECX);
     }
     return;
   }
+
+  const String& growable_object_array_class_name = String::Handle(
+      String::NewSymbol(kGrowableArrayClassName));
+  const Class& growable_array_class = Class::ZoneHandle(
+      Library::Handle(Library::CoreImplLibrary()).
+          LookupClass(growable_object_array_class_name));
+  ASSERT(!growable_array_class.IsNull());
+  if (AtIdNodeHasOnlyClass(node, node->id(), growable_array_class)) {
+    const String& growable_array_length_field_name =
+        String::Handle(String::NewSymbol(kGrowableArrayLengthFieldName));
+    const String& growable_array_array_field_name =
+        String::Handle(String::NewSymbol(kGrowableArrayArrayFieldName));
+    intptr_t length_offset = GetFieldOffset(growable_array_class,
+                                            growable_array_length_field_name);
+    intptr_t array_offset = GetFieldOffset(growable_array_class,
+                                           growable_array_array_field_name);
+    VisitLoadTwo(node->index_expr(), node->value(), EBX, ECX);
+    DeoptimizationBlob* deopt_blob =
+        AddDeoptimizationBlob(node, EAX, EBX, ECX, kDeoptStoreIndexed);
+    __ popl(EAX);  // Array.
+    // ECX: value, EBX:index, EAX: array, EDX: scratch.
+    // Check class of array.
+    __ testl(EAX, Immediate(kSmiTagMask));
+    __ j(ZERO, deopt_blob->label());  // Array is smi -> deopt.
+    __ movl(EDX, FieldAddress(EAX, Object::class_offset()));
+    __ CompareObject(EDX, growable_array_class);
+    __ j(NOT_EQUAL, deopt_blob->label());  // Not GrowableObjectArray -> deopt.
+    // Check class of index.
+    __ testl(EBX, Immediate(kSmiTagMask));
+    __ j(NOT_ZERO, deopt_blob->label());  // Index not Smi -> deopt.
+    // Range check: deoptimize if out of bounds.
+    __ cmpl(EBX, FieldAddress(EAX, length_offset));
+    __ j(ABOVE_EQUAL, deopt_blob->label());
+    __ movl(EDX, FieldAddress(EAX, array_offset));  // backingArray.
+    // Note that EAX is Smi, i.e, times 2.
+    ASSERT(kSmiTagShift == 1);
+    __ StoreIntoObject(EDX,
+                       FieldAddress(EDX, EBX, TIMES_2, sizeof(RawArray)),
+                       ECX);
+    if (CodeGenerator::IsResultNeeded(node)) {
+      __ pushl(ECX);
+    }
+    return;
+  }
   node->index_expr()->Visit(this);
   node->value()->Visit(this);
   GenerateStoreIndexed(node->id(), node->token_index(), IsResultNeeded(node));
 }
 
 
 void OptimizingCodeGenerator::VisitForNode(ForNode* node) {
   if (FLAG_enable_type_checks) {
     CodeGenerator::VisitForNode(node);
     return;
@@ skipping 543 matching lines @@
     }
   }
   // TODO(srdjan): Implement unary kSUB (negate) Mint.
   CodeGenerator::VisitUnaryOpNode(node);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32