Optimize indexed store for growable array (intrinsification and inlined optimized).

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 52 matching lines @@
   V(Double, /, Double_div)                                                     \
   V(Double, toDouble, Double_toDouble)                                         \
   V(Double, mulFromInteger, Double_mulFromInteger)                             \
   V(Double, Double.fromInteger, Double_fromInteger)                            \
   V(ObjectArray, ObjectArray., ObjectArray_Allocate)                           \
   V(ObjectArray, get:length, Array_getLength)                                  \
   V(ObjectArray, [], Array_getIndexed)                                         \
   V(ObjectArray, []=, Array_setIndexed)                                        \
   V(GrowableObjectArray, get:length, GrowableArray_getLength)                  \
   V(GrowableObjectArray, [], GrowableArray_getIndexed)                         \
+  V(GrowableObjectArray, []=, GrowableArray_setIndexed)                        \
   V(ImmutableArray, [], Array_getIndexed)                                      \
   V(ImmutableArray, get:length, Array_getLength)                               \
   V(Math, sqrt, Math_sqrt)                                                     \
   V(Object, ==, Object_equal)                                                  \
   V(FixedSizeArrayIterator, next, FixedSizeArrayIterator_next)                 \
   V(FixedSizeArrayIterator, hasNext, FixedSizeArrayIterator_hasNext)           \
   V(StringBase, get:length, String_getLength)                                  \
   V(StringBase, charCodeAt, String_charCodeAt)                                 \
   V(StringBase, hashCode, String_hashCode)                                     \
   V(StringBase, isEmpty, String_isEmpty)                                       \
@@ skipping 108 matching lines @@
 
 // Intrinsify only for Smi value and index. Non-smi values need a store buffer
 // update. Array length is always a Smi.
 static bool Array_setIndexed(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return false;
   }
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   Label fall_through;
-  __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Value.
   __ movl(EBX, Address(ESP, + 2 * kWordSize));  // Index.
-  __ orl(EAX, EBX);
-  __ testl(EAX, Immediate(kSmiTagMask));
-  // Value or index not Smi.
+  __ testl(EBX, Immediate(kSmiTagMask));
+  // Index not Smi.
   __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);
   __ movl(EAX, Address(ESP, + 3 * kWordSize));  // Array.
   // Range check.
   __ cmpl(EBX, FieldAddress(EAX, Array::length_offset()));
   // Runtime throws exception.
   __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
   // Note that EBX is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   // Destroy ECX as we will not continue in the function.
-  __ movl(ECX, Address(ESP, + 1 * kWordSize));
+  __ movl(ECX, Address(ESP, + 1 * kWordSize));  // Value.
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)),
                      ECX);
   // Caller is responsible of preserving the value if necessary.
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
@@ skipping 28 matching lines @@
 static bool GrowableArray_getIndexed(Assembler* assembler) {
   intptr_t length_offset = GetOffsetForField(kGrowableArrayClassName,
                                              kGrowableArrayLengthFieldName);
   intptr_t array_offset = GetOffsetForField(kGrowableArrayClassName,
                                             kGrowableArrayArrayFieldName);
   Label fall_through;
   __ movl(EBX, Address(ESP, + 1 * kWordSize));  // Index.
   __ movl(EAX, Address(ESP, + 2 * kWordSize));  // GrowableArray.
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
-  // Range check.
+  // Range check using _length field.
   __ cmpl(EBX, FieldAddress(EAX, length_offset));
   // Runtime throws exception.
   __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
   __ movl(EAX, FieldAddress(EAX, array_offset));  // backingArray.
 
   // Note that EBX is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   __ movl(EAX, FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)));
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
+// On stack: array (+3), index (+2), value (+1), return-address (+0).
+static bool GrowableArray_setIndexed(Assembler* assembler) {
+  if (FLAG_enable_type_checks) {
+    return false;
+  }
+  Label fall_through;
+  intptr_t length_offset = GetOffsetForField(kGrowableArrayClassName,
+                                             kGrowableArrayLengthFieldName);
+  intptr_t array_offset = GetOffsetForField(kGrowableArrayClassName,
+                                            kGrowableArrayArrayFieldName);
+  __ movl(EBX, Address(ESP, + 2 * kWordSize));  // Index.
+  __ movl(EAX, Address(ESP, + 3 * kWordSize));  // GrowableArray.
+  __ testl(EBX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check using _length field.
+  __ cmpl(EBX, FieldAddress(EAX, length_offset));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+  __ movl(EAX, FieldAddress(EAX, array_offset));  // backingArray.
+  __ movl(EDI, Address(ESP, + 1 * kWordSize));  // Value.
+  // Note that EBX is Smi, i.e, times 2.
+  ASSERT(kSmiTagShift == 1);
+  __ StoreIntoObject(EAX,
+                     FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)),
+                     EDI);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in EAX.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(EBX, Address(ESP, + 2 * kWordSize));
   __ orl(EBX, EAX);
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, not_smi, Assembler::kNearJump);
 }
 
@@ skipping 723 matching lines @@
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32