Refactor ProfileInfoCacheObserver interface and usage thereof.

chrome/browser/profiles/profile_info_cache_observer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_OBSERVER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_OBSERVER_H_
 #pragma once
 
 #include "ui/gfx/image/image.h"
 
 class FilePath;
 
 // This class provides an Observer interface to watch for changes to the
 // ProfileInfoCache.
 class ProfileInfoCacheObserver {
  public:
   virtual ~ProfileInfoCacheObserver() {}
 
   virtual void OnProfileAdded(
-      const string16& profile_name,
-      const string16& profile_base_dir,
       const FilePath& profile_path,
-      const gfx::Image* avatar_image) = 0;
+      const string16& profile_base_dir) = 0;

[SteveT, 2011/12/21 17:12:45]

I would love to remove |profile_base_dir| as well, which you can get by calling
ProfileInfoCache::CacheKeyFromProfilePath() on |profile_path|... Unfortunately,
this is a private member method. Are we cool with making this public?

[sail, 2011/12/21 17:51:10]

Hi Steve, do you actually need the profile_base_dir here? If you need the unique
directory name that the profile is saved in then you can just get that from the
last component of profile_path. (something like FilePath::BaseName() i think).

[SteveT, 2011/12/21 20:47:03]

As I commented above - no we don't, but unfortunately we'll have to duplicate
some code to get it from |profile_path| unless we make CacheKeyFromProfilePath
public.

I'll do as you suggested, but let me know if it makes sense for us to make
CacheKeyFromProfilePath public to save some code duplication.

[sail, 2011/12/21 21:04:12]

I think the Cache key concept should remain private. Currently it's the profile
directory but there's no guarantee that it'll remain so. 

   virtual void OnProfileWillBeRemoved(
       const string16& profile_name) = 0;

[sail, 2011/12/21 17:51:10]

If possible, could you change all the callbacks to simply take the full profile
path? It seems like that would be all you need. The only exception would be
OnProfileWasRemoved and OnProfileNameChanged. For those two callbacks, they full
profile path should also be included.

[SteveT, 2011/12/21 20:47:03]

Sounds good. All done - except I had to include the profile_name along side the
profile_path in OnProfileWasRemoved, as we are no longer able to retrieve the
name of the removed profile from the cache by using the old profile_path.

   virtual void OnProfileWasRemoved(
       const string16& profile_name) = 0;
   virtual void OnProfileNameChanged(
       const string16& old_profile_name,
       const string16& new_profile_name) = 0;
   virtual void OnProfileAvatarChanged(
-      const string16& profile_name,
-      const string16& profile_base_dir,
       const FilePath& profile_path,
-      const gfx::Image* avatar_image) = 0;
+      const string16& profile_base_dir) = 0;

[SteveT, 2011/12/21 17:12:45]

As above.

 
  protected:
   ProfileInfoCacheObserver() {}
 
   DISALLOW_COPY_AND_ASSIGN(ProfileInfoCacheObserver);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_OBSERVER_H_