Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: dart/frog/leg/resolver.dart

Issue 9019018: Fix resolver for fields uses in constructors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/tests/leg/src/ResolverTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/resolver.dart
===================================================================
--- dart/frog/leg/resolver.dart (revision 2706)
+++ dart/frog/leg/resolver.dart (working copy)
@@ -119,7 +119,8 @@
: this.compiler = compiler,
this.mapping = new TreeElements(),
this.enclosingElement = element,
- inInstanceContext = element.isInstanceMember(),
+ inInstanceContext =
+ element.isInstanceMember() || element.kind == ElementKind.CONSTRUCTOR,
this.context = element.isMember()
? new ClassScope(element.enclosingElement, compiler.universe)
: new TopScope(compiler.universe);
@@ -375,7 +376,7 @@
SourceString opName = mapOperatorToMethodName(name, node.isPrefix);
target = compiler.universe.find(opName);
} else if (node.receiver === null) {
- target = visit(selector);
+ target = lookup(node, name);
if (target == null && !enclosingElement.isInstanceMember()) {
error(node, MessageKind.CANNOT_RESOLVE, [name]);
}
@@ -419,7 +420,8 @@
if (node.isIndex) {
getter = target;
} else {
- getter = visit(node.selector);
+ // TODO(ngeoffray): Find the getter from the setter.
+ getter = context.lookup(node.selector.asIdentifier().source);
}
useElement(node.selector, getter);
}
« no previous file with comments | « no previous file | dart/frog/tests/leg/src/ResolverTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698