Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: content/browser/plugin_data_remover_impl.cc

Issue 9019010: Replace DFATAL with ERROR in PluginDataRemover::OnError. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/plugin_data_remover_impl.h" 5 #include "content/browser/plugin_data_remover_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/synchronization/waitable_event.h" 9 #include "base/synchronization/waitable_event.h"
10 #include "base/version.h" 10 #include "base/version.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 virtual void OnSentPluginChannelRequest() OVERRIDE { 129 virtual void OnSentPluginChannelRequest() OVERRIDE {
130 } 130 }
131 131
132 virtual void OnChannelOpened(const IPC::ChannelHandle& handle) OVERRIDE { 132 virtual void OnChannelOpened(const IPC::ChannelHandle& handle) OVERRIDE {
133 ConnectToChannel(handle); 133 ConnectToChannel(handle);
134 // Balancing the AddRef call. 134 // Balancing the AddRef call.
135 Release(); 135 Release();
136 } 136 }
137 137
138 virtual void OnError() OVERRIDE { 138 virtual void OnError() OVERRIDE {
139 LOG(DFATAL) << "Couldn't open plugin channel"; 139 LOG(ERROR) << "Couldn't open plugin channel";
140 SignalDone(); 140 SignalDone();
141 // Balancing the AddRef call. 141 // Balancing the AddRef call.
142 Release(); 142 Release();
143 } 143 }
144 144
145 // IPC::Channel::Listener methods. 145 // IPC::Channel::Listener methods.
146 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE { 146 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE {
147 IPC_BEGIN_MESSAGE_MAP(Context, message) 147 IPC_BEGIN_MESSAGE_MAP(Context, message)
148 IPC_MESSAGE_HANDLER(PluginHostMsg_ClearSiteDataResult, 148 IPC_MESSAGE_HANDLER(PluginHostMsg_ClearSiteDataResult,
149 OnClearSiteDataResult) 149 OnClearSiteDataResult)
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 PluginDataRemoverImpl::~PluginDataRemoverImpl() { 231 PluginDataRemoverImpl::~PluginDataRemoverImpl() {
232 } 232 }
233 233
234 base::WaitableEvent* PluginDataRemoverImpl::StartRemoving( 234 base::WaitableEvent* PluginDataRemoverImpl::StartRemoving(
235 base::Time begin_time) { 235 base::Time begin_time) {
236 DCHECK(!context_.get()); 236 DCHECK(!context_.get());
237 context_ = new Context(begin_time, resource_context_); 237 context_ = new Context(begin_time, resource_context_);
238 context_->Init(mime_type_); 238 context_->Init(mime_type_);
239 return context_->event(); 239 return context_->event();
240 } 240 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698