Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9019004: Rename PluginService to PluginServiceImpl. (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Nico
CC:
chromium-reviews, jstritar+watch_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, stuartmorgan+watch_chromium.org, amit, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., robertshield, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename PluginService to PluginServiceImpl. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115279

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -1358 lines) Patch
M chrome/browser/DEPS View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_prefs_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/enterprise_metrics_enrollment_browsertest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_loader_posix.h View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/browser/plugin_service.h View 1 2 3 1 chunk +0 lines, -239 lines 0 comments Download
D content/browser/plugin_service.cc View 1 2 3 1 chunk +0 lines, -678 lines 0 comments Download
D content/browser/plugin_service_browsertest.cc View 1 2 3 1 chunk +0 lines, -311 lines 0 comments Download
A + content/browser/plugin_service_impl.h View 1 5 chunks +13 lines, -15 lines 0 comments Download
A + content/browser/plugin_service_impl.cc View 29 chunks +68 lines, -63 lines 0 comments Download
A + content/browser/plugin_service_impl_browsertest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/plugin_service.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/shell_browser_main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years ago (2011-12-21 03:27:10 UTC) #1
Nico
lgtm Maybe send a manual tryjob to linux_shared for now. http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_service_impl.h File content/browser/plugin_service_impl.h (left): http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_service_impl.h#oldcode237 ...
9 years ago (2011-12-21 03:38:38 UTC) #2
jam
9 years ago (2011-12-21 04:56:50 UTC) #3 
I'll send a manual tryjob per your suggestion well

http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_servi...
File content/browser/plugin_service_impl.h (left):

http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_servi...
content/browser/plugin_service_impl.h:237:
DISABLE_RUNNABLE_METHOD_REFCOUNT(PluginService);
On 2011/12/21 03:38:39, Nico wrote:
> Did you lose this intentionally?

it's not needed anymore now that we use bind

http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_servi...
File content/browser/plugin_service_impl_browsertest.cc (right):

http://codereview.chromium.org/9019004/diff/1032/content/browser/plugin_servi...
content/browser/plugin_service_impl_browsertest.cc:12: #include
"content/browser/plugin_service_impl.h"
On 2011/12/21 03:38:39, Nico wrote:
> Nit: the style guide says that the header for a test file should be at the
top:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_...
> I guess that applies to _browsertest files as well.

oh, that's new to me. I just checked and it got updated a month ago. i don't
know why this was done, since it seems redundant to enforce this for the test
file. but i'll revert this change then.

Powered by Google App Engine
This is Rietveld 408576698