Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: webkit/port/bindings/v8/v8_nodefilter.cpp

Issue 9019: Make ExceptionContext platform-independent using magic headers (2/2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/port/bindings/v8/v8_custom.cpp ('k') | webkit/port/bridge/ExceptionContextV8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/v8_nodefilter.cpp
===================================================================
--- webkit/port/bindings/v8/v8_nodefilter.cpp (revision 4425)
+++ webkit/port/bindings/v8/v8_nodefilter.cpp (working copy)
@@ -58,7 +58,7 @@
if (!m_filter->IsFunction()) return NodeFilter::FILTER_ACCEPT;
- ExceptionCatcher exception_catcher(exception_context);
+ v8::TryCatch exception_catcher;
v8::Handle<v8::Object> this_obj = v8::Context::GetCurrent()->Global();
v8::Handle<v8::Function> callback =
@@ -73,7 +73,8 @@
proxy->CallFunction(callback, this_obj, 1, args);
delete[] args;
- if (exception_context->hadException()) {
+ if (exception_catcher.HasCaught()) {
+ exception_context->setData(exception_catcher.Exception());
return NodeFilter::FILTER_REJECT;
}
« no previous file with comments | « webkit/port/bindings/v8/v8_custom.cpp ('k') | webkit/port/bridge/ExceptionContextV8.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698