Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1720)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

Issue 9018016: Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
index 4c1eb2ed4d98918b8a1528ba966469a3b4c5cac2..0fe86e454f5149360907ed9ff0165e811381748e 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
@@ -209,8 +209,8 @@ void GeolocationPermissionContextTests::CheckPermissionMessageSentInternal(
void GeolocationPermissionContextTests::AddNewTab(const GURL& url) {
TabContents* new_tab =
new TabContents(profile(), NULL, MSG_ROUTING_NONE, NULL, NULL);
- new_tab->GetController().LoadURL(
- url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
+ new_tab->controller().LoadURL(url, content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
static_cast<TestRenderViewHost*>(new_tab->render_manager_for_testing()->
current_host())->SendNavigate(extra_tabs_.size() + 1, url);
extra_tabs_.push_back(new TabContentsWrapper(new_tab));
@@ -579,7 +579,7 @@ TEST_F(GeolocationPermissionContextTests, InfoBarUsesCommittedEntry) {
EXPECT_EQ(0U, infobar_tab_helper()->infobar_count());
// Go back: navigate to a pending entry before requesting geolocation
// permission.
- contents()->GetController().GoBack();
+ contents()->controller().GoBack();
// Request permission for the committed frame (not the pending one).
RequestGeolocationPermission(
process_id(), render_id(), bridge_id(), requesting_frame_1);
@@ -589,11 +589,11 @@ TEST_F(GeolocationPermissionContextTests, InfoBarUsesCommittedEntry) {
ASSERT_TRUE(infobar_0);
// Ensure the infobar is not yet expired.
content::LoadCommittedDetails details;
- details.entry = contents()->GetController().GetLastCommittedEntry();
+ details.entry = contents()->controller().GetLastCommittedEntry();
ASSERT_FALSE(infobar_0->ShouldExpire(details));
// Commit the "GoBack()" above, and ensure the infobar is now expired.
contents()->CommitPendingNavigation();
- details.entry = contents()->GetController().GetLastCommittedEntry();
+ details.entry = contents()->controller().GetLastCommittedEntry();
ASSERT_TRUE(infobar_0->ShouldExpire(details));
// Delete the tab contents.

Powered by Google App Engine
This is Rietveld 408576698