Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

Issue 9018016: Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
6 6
7 #include "chrome/browser/bookmarks/bookmark_model.h" 7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/bookmarks/bookmark_node_data.h" 8 #include "chrome/browser/bookmarks/bookmark_node_data.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h" 10 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 } 42 }
43 43
44 bool BookmarkTabHelper::ShouldShowBookmarkBar() { 44 bool BookmarkTabHelper::ShouldShowBookmarkBar() {
45 if (tab_contents()->showing_interstitial_page()) 45 if (tab_contents()->showing_interstitial_page())
46 return false; 46 return false;
47 47
48 // See TabContents::GetWebUIForCurrentState() comment for more info. This case 48 // See TabContents::GetWebUIForCurrentState() comment for more info. This case
49 // is very similar, but for non-first loads, we want to use the committed 49 // is very similar, but for non-first loads, we want to use the committed
50 // entry. This is so the bookmarks bar disappears at the same time the page 50 // entry. This is so the bookmarks bar disappears at the same time the page
51 // does. 51 // does.
52 if (tab_contents()->GetController().GetLastCommittedEntry()) { 52 if (tab_contents()->controller().GetLastCommittedEntry()) {
53 // Not the first load, always use the committed Web UI. 53 // Not the first load, always use the committed Web UI.
54 return CanShowBookmarkBar(tab_contents()->committed_web_ui()); 54 return CanShowBookmarkBar(tab_contents()->committed_web_ui());
55 } 55 }
56 56
57 // When it's the first load, we know either the pending one or the committed 57 // When it's the first load, we know either the pending one or the committed
58 // one will have the Web UI in it (see GetWebUIForCurrentState), and only one 58 // one will have the Web UI in it (see GetWebUIForCurrentState), and only one
59 // of them will be valid, so we can just check both. 59 // of them will be valid, so we can just check both.
60 return CanShowBookmarkBar(tab_contents()->web_ui()); 60 return CanShowBookmarkBar(tab_contents()->web_ui());
61 } 61 }
62 62
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 void BookmarkTabHelper::UpdateStarredStateForCurrentURL() { 102 void BookmarkTabHelper::UpdateStarredStateForCurrentURL() {
103 Profile* profile = 103 Profile* profile =
104 Profile::FromBrowserContext(tab_contents()->browser_context()); 104 Profile::FromBrowserContext(tab_contents()->browser_context());
105 BookmarkModel* model = profile->GetBookmarkModel(); 105 BookmarkModel* model = profile->GetBookmarkModel();
106 const bool old_state = is_starred_; 106 const bool old_state = is_starred_;
107 is_starred_ = (model && model->IsBookmarked(tab_contents()->GetURL())); 107 is_starred_ = (model && model->IsBookmarked(tab_contents()->GetURL()));
108 108
109 if (is_starred_ != old_state && delegate()) 109 if (is_starred_ != old_state && delegate())
110 delegate()->URLStarredChanged(tab_contents_wrapper_, is_starred_); 110 delegate()->URLStarredChanged(tab_contents_wrapper_, is_starred_);
111 } 111 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698