Issue 9018013: Enable max optimization for v8 in chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9018013: Enable max optimization for v8 in chromium. (Closed)

Created:
9 years ago by Rico

Modified:
9 years ago

Reviewers:
Sigurður Ásgeirsson

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Enable max optimization for v8 in chromium. First attempt to do this failed, we need per target flags. Committed: http://code.google.com/p/v8/source/detail?r=10297

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

9 years ago (2011-12-21 14:55:39 UTC) #2

LGTM with the comment addressed.

http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp#newcode224
tools/gyp/v8.gyp:224: 'optimize': 'max',
That needs to be 
          'variables': {
            'optimize': 'max',
          },

Expand Messages | Collapse Messages