Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9018013: Enable max optimization for v8 in chromium. (Closed)

Created:
9 years ago by Rico
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Enable max optimization for v8 in chromium. First attempt to do this failed, we need per target flags. Committed: http://code.google.com/p/v8/source/detail?r=10297

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Rico
9 years ago (2011-12-21 14:43:49 UTC) #1
Sigurður Ásgeirsson
9 years ago (2011-12-21 14:55:39 UTC) #2
LGTM with the comment addressed.

http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp#newcode224
tools/gyp/v8.gyp:224: 'optimize': 'max',
That needs to be 
          'variables': {
            'optimize': 'max',
          },

Powered by Google App Engine
This is Rietveld 408576698