Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 9018: Make ExceptionContext platform-independent using magic headers (1/2) (Closed)

Created:
12 years, 1 month ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make ExceptionContext platform-independent using magic headers. This is part 1 of the exciting story, involving exceptions, catching them, and carrying them around. See? Exciting! part two is here: http://codereview.chromium.org/9019

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -121 lines) Patch
D third_party/WebKit/WebCore/bindings/js/ExceptionContext.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
A third_party/WebKit/WebCore/bindings/js/ExceptionContextData.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/WebCore/bindings/js/JSNodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/WebCore/dom/ExceptionContext.h View 1 1 chunk +8 lines, -50 lines 0 comments Download
A + third_party/WebKit/WebCore/dom/ExceptionContext.cpp View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
Since you're not asleep or resting away from the keyboard in this lazy Saturday night, ...
12 years, 1 month ago (2008-11-02 03:53:15 UTC) #1
brettw
12 years, 1 month ago (2008-11-02 04:15:27 UTC) #2
LGTM

http://codereview.chromium.org/9018/diff/1/3
File third_party/WebKit/WebCore/bindings/js/ExceptionContextData.h (right):

http://codereview.chromium.org/9018/diff/1/3#newcode32
Line 32: #endif  // !defined(ExceptionContextData_h)
Don't use the !defined( here, just the guard name is OK.

Powered by Google App Engine
This is Rietveld 408576698