X64: check all cases with "__ movq(FieldAddress" and converted them to StoreIntoObject if appropr...

vm/stub_code_x64.cc

Index: vm/stub_code_x64.cc
===================================================================
--- vm/stub_code_x64.cc	(revision 2709)
+++ vm/stub_code_x64.cc	(working copy)
@@ -614,16 +614,18 @@
     // R10: Array length as Smi.
 
     // Store the type argument field.
-    __ movq(FieldAddress(RAX, Array::type_arguments_offset()), RBX);
+    __ StoreIntoObject(RAX,
+                       FieldAddress(RAX, Array::type_arguments_offset()),
+                       RBX);
 
     // Set the length field.
-    __ movq(FieldAddress(RAX, Array::length_offset()), R10);
+    __ StoreIntoObject(RAX, FieldAddress(RAX, Array::length_offset()), R10);

[cshapiro, 2011/12/21 19:45:06]

This should always be a SMI so a store check would seem redundant.

[srdjan, 2011/12/21 21:29:12]

I am concerned to add here an implicit knwoledge that length is a Smi.

 
     // Store class value for array.
     __ movq(RBX, FieldAddress(CTX, Context::isolate_offset()));
     __ movq(RBX, Address(RBX, Isolate::object_store_offset()));
     __ movq(RBX, Address(RBX, ObjectStore::array_class_offset()));
-    __ movq(FieldAddress(RAX, Array::class_offset()), RBX);
+    __ StoreIntoObject(RAX, FieldAddress(RAX, Array::class_offset()), RBX);
     __ movq(FieldAddress(RAX, Array::tags_offset()), Immediate(0));  // Tags.
 
     // Initialize all array elements to raw_null.