X64: check all cases with "__ movq(FieldAddress" and converted them to StoreIntoObject if appropr...

vm/stub_code_x64.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/ic_data.h"
@@ skipping 596 matching lines @@
     // R13: Points to new space object.
     __ movq(Address(R13, Scavenger::top_offset()), R12);
     __ addq(RAX, Immediate(kHeapObjectTag));
 
     // RAX: new object start as a tagged pointer.
     // R12: new object end address.
     // RBX: array element type.
     // R10: Array length as Smi.
 
     // Store the type argument field.
-    __ movq(FieldAddress(RAX, Array::type_arguments_offset()), RBX);
+    __ StoreIntoObject(RAX,
+                       FieldAddress(RAX, Array::type_arguments_offset()),
+                       RBX);
 
     // Set the length field.
-    __ movq(FieldAddress(RAX, Array::length_offset()), R10);
+    __ StoreIntoObject(RAX, FieldAddress(RAX, Array::length_offset()), R10);

[cshapiro, 2011/12/21 19:45:06]

This should always be a SMI so a store check would seem redundant.

[srdjan, 2011/12/21 21:29:12]

I am concerned to add here an implicit knwoledge that length is a Smi.

 
     // Store class value for array.
     __ movq(RBX, FieldAddress(CTX, Context::isolate_offset()));
     __ movq(RBX, Address(RBX, Isolate::object_store_offset()));
     __ movq(RBX, Address(RBX, ObjectStore::array_class_offset()));
-    __ movq(FieldAddress(RAX, Array::class_offset()), RBX);
+    __ StoreIntoObject(RAX, FieldAddress(RAX, Array::class_offset()), RBX);
     __ movq(FieldAddress(RAX, Array::tags_offset()), Immediate(0));  // Tags.
 
     // Initialize all array elements to raw_null.
     // RAX: new object start as a tagged pointer.
     // R12: new object end address.
     // RBX: iterator which initially points to the start of the variable
     // data area to be initialized.
     __ leaq(RBX, FieldAddress(RAX, Array::data_offset()));
     Label done;
     Label init_loop;
@@ skipping 526 matching lines @@
 }
 
 
 void StubCode::GenerateBreakpointDynamicStub(Assembler* assembler) {
   __ Unimplemented("BreakpointDynamic stub");
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64