Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 9017004: Add max optimization flag to v8 build flag, chrome will use less optimization as default soon. (Closed)

Created:
9 years ago by Rico
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Add max optimization flag to v8 build flag, chrome will use less optimization as default soon. Committed: http://code.google.com/p/v8/source/detail?r=10283

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Rico
9 years ago (2011-12-21 07:07:24 UTC) #1
danno
lgtm
9 years ago (2011-12-21 07:27:39 UTC) #2
Sigurður Ásgeirsson
http://codereview.chromium.org/9017004/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/9017004/diff/1/build/common.gypi#newcode90 build/common.gypi:90: 'optimize': 'max', This is a little indiscriminate, I'd very ...
9 years ago (2011-12-21 14:16:06 UTC) #3
Sigurður Ásgeirsson
9 years ago (2011-12-21 14:38:46 UTC) #4
I just checked out ToT, and this change doesn't enable WPO optimizations for V8
targets.
Please do this on a per-target basis. From looking at the targets Chrome depends
on, you probably only want to do this for v8_base in
http://v8.googlecode.com/svn/branches/bleeding_edge/tools/gyp/v8.gyp.
There's no reason to enable WPO for targets that contain code that runs very
seldom...

Powered by Google App Engine
This is Rietveld 408576698