Issue 9016041: Ensure that InternalArrays remain InternalArrays regardless of how they are constructed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9016041: Ensure that InternalArrays remain InternalArrays regardless of how they are constructed. (Closed)

Created:
8 years, 12 months ago by danno

Modified:
8 years, 12 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Ensure that InternalArrays remain InternalArrays regardless of how they are constructed. R=whesse@chromium.org BUG=v8:1878 TEST=test/mjsunit/regress/regress-1878.js Committed: http://code.google.com/p/v8/source/detail?r=10306

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -4 lines)			Patch
M	src/arm/builtins-arm.cc	View	1	2 chunks	+50 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/contexts.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1 2 3	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-1878.js	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

8 years, 12 months ago (2011-12-27 15:08:30 UTC) #2

LGTM, if the fallthrough to ArrayCodeGeneric case is handled in a later CL or a
bug is filed.