Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6007)

Unified Diff: chrome/browser/ui/cocoa/first_run_bubble_controller.mm

Issue 9016036: Implement the new first run bubble, clean up old bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge, fix SetShowFirstRunBubblePref and test, update copyright years. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/first_run_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/first_run_bubble_controller.mm b/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
index 2c68cdc050eb01a3864b36e880e273525d4160bd..abcf0c5a355288691216e0549465e7d6a8f2e0e4 100644
--- a/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/browser_list.h"
Miranda Callahan 2012/01/10 22:25:47 nit: alphaordering
msw 2012/01/11 00:27:10 Done.
#include "chrome/browser/search_engines/util.h"
#import "chrome/browser/ui/cocoa/l10n_util.h"
#import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ -54,7 +55,7 @@
[header_ setStringValue:cocoa_l10n_util::ReplaceNSStringPlaceholders(
[header_ stringValue], GetDefaultSearchEngineName(profile_), NULL)];
- // Adapt window size to bottom buttons. Do this before all other layouting.
+ // Adapt window size to contents. Do this before all other layouting.
CGFloat dy = cocoa_l10n_util::VerticallyReflowGroup([[self bubble] subviews]);
NSSize ds = NSMakeSize(0, dy);
ds = [[self bubble] convertSize:ds toView:nil];
@@ -79,4 +80,11 @@
[self close];
}
+- (IBAction)onChange:(id)sender {
+ Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+ [self close];
+ if (browser)
+ browser->OpenSearchEngineOptionsDialog();
+}
+
@end // FirstRunBubbleController

Powered by Google App Engine
This is Rietveld 408576698