Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 9016030: Missing plugin : Fix null mimetype issue in embed tag (Closed)

Created:
9 years ago by cpu_(ooo_6.6-7.5)
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Missing plugin : Fix null mimetype issue in embed tag In chrome 16,17,18 if you have an embed tag, say flash that has no type information, like: <embed width="100%" name="plugin" src="foo.swf" > without the type attribute, like type="application/x-shockwave-flash" Chrome shows the "missing plugin" element instead of flash. This uses chrome's knowledge of the mime type instead of just passing webkit's notion of the mime type which in this case is empty (""). BUG=108228 TEST=see bug for easy repro case. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
It is not clear if this is a fallout of a webkit regression but I ...
9 years ago (2011-12-21 23:30:50 UTC) #1
jam
9 years ago (2011-12-21 23:34:28 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698