Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/browser/extensions/extension_file_browser_private_api.cc

Issue 9016020: Cleanup FileSystemOperation for preparing for adding FSO-factory method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more cleanup around ValidateFileSystemRoot Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_file_browser_private_api.cc
diff --git a/chrome/browser/extensions/extension_file_browser_private_api.cc b/chrome/browser/extensions/extension_file_browser_private_api.cc
index 09b38d2ce31b7e3f27f89ad742126910145b68a2..f02921f6f144b3356b2c71aeeee9f39f750a3dc9 100644
--- a/chrome/browser/extensions/extension_file_browser_private_api.cc
+++ b/chrome/browser/extensions/extension_file_browser_private_api.cc
@@ -44,7 +44,6 @@
#include "webkit/fileapi/file_system_context.h"
#include "webkit/fileapi/file_system_file_util.h"
#include "webkit/fileapi/file_system_mount_point_provider.h"
-#include "webkit/fileapi/file_system_operation.h"
#include "webkit/fileapi/file_system_operation_context.h"
#include "webkit/fileapi/file_system_types.h"
#include "webkit/fileapi/file_system_util.h"
@@ -411,18 +410,14 @@ class RequestLocalFileSystemFunction::LocalFileSystemCallbackDispatcher
void RequestLocalFileSystemFunction::RequestOnFileThread(
const GURL& source_url, int child_id) {
- fileapi::FileSystemOperation* operation =
- new fileapi::FileSystemOperation(
- new LocalFileSystemCallbackDispatcher(
- this,
- profile(),
- child_id,
- GetExtension()),
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
- profile()->GetFileSystemContext());
GURL origin_url = source_url.GetOrigin();
- operation->OpenFileSystem(origin_url, fileapi::kFileSystemTypeExternal,
- false); // create
+ profile()->GetFileSystemContext()->OpenFileSystem(
+ origin_url, fileapi::kFileSystemTypeExternal, false, // create
+ new LocalFileSystemCallbackDispatcher(
+ this,
+ profile(),
+ child_id,
+ GetExtension()));
}
bool RequestLocalFileSystemFunction::RunImpl() {
@@ -865,21 +860,17 @@ void ExecuteTasksFileBrowserFunction::RequestFileEntryOnFileThread(
const GURL& source_url, const std::string& task_id,
const std::vector<GURL>& file_urls) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- fileapi::FileSystemOperation* operation =
- new fileapi::FileSystemOperation(
- new ExecuteTasksFileSystemCallbackDispatcher(
- this,
- profile(),
- render_view_host()->process()->GetID(),
- source_url,
- GetExtension(),
- task_id,
- file_urls),
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
- profile()->GetFileSystemContext());
GURL origin_url = source_url.GetOrigin();
- operation->OpenFileSystem(origin_url, fileapi::kFileSystemTypeExternal,
- false); // create
+ profile()->GetFileSystemContext()->OpenFileSystem(
+ origin_url, fileapi::kFileSystemTypeExternal, false, // create
+ new ExecuteTasksFileSystemCallbackDispatcher(
+ this,
+ profile(),
+ render_view_host()->process()->GetID(),
+ source_url,
+ GetExtension(),
+ task_id,
+ file_urls));
}
void ExecuteTasksFileBrowserFunction::ExecuteFailedOnUIThread() {

Powered by Google App Engine
This is Rietveld 408576698