Cleanup FileSystemOperation for preparing for adding FSO-factory method

webkit/fileapi/file_system_context.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/platform_file.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/quota/special_storage_policy.h"
 
 class FilePath;
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace quota {
 class QuotaManagerProxy;
 }
 
 namespace fileapi {
 
 class ExternalFileSystemMountPointProvider;
+class FileSystemCallbackDispatcher;
 class FileSystemContext;
 class FileSystemFileUtil;
 class FileSystemMountPointProvider;
 class FileSystemOptions;
 class FileSystemPathManager;
 class FileSystemQuotaUtil;
 class SandboxMountPointProvider;
 
 struct DefaultContextDeleter;
 
@@ skipping 41 matching lines @@
   // Returns a FileSystemMountPointProvider instance for sandboxed filesystem
   // types (e.g. TEMPORARY or PERSISTENT).  This is equivalent to calling
   // GetMountPointProvider(kFileSystemType{Temporary, Persistent}).
   SandboxMountPointProvider* sandbox_provider() const;
 
   // Returns a FileSystemMountPointProvider instance for external filesystem
   // type, which is used only by chromeos for now.  This is equivalent to
   // calling GetMountPointProvider(kFileSystemTypeExternal).
   ExternalFileSystemMountPointProvider* external_provider() const;
 
+  // Opens the filesystem for the given origin and type and dispatches

[satorux1, 2011/12/27 18:56:37]

"and type and dispatches" is a bit confusing. adding a comma may be helpful.

"and type, and dispatches"

[kinuko, 2011/12/28 10:59:35]

Done.

+  // the DidOpenFileSystem callback of the given |dispatcher|.
+  // If |create| is true this may actually setup a filesystem instance
+  // (e.g. by creating the root directory or initializing the database
+  // entry etc).
+  // TODO(kinuko): replace the dispatcher with regular callback.
+  void OpenFileSystem(
+      const GURL& origin_url,
+      FileSystemType type,
+      bool create,
+      FileSystemCallbackDispatcher* dispatcher);
+
  private:
   friend struct DefaultContextDeleter;
   void DeleteOnCorrectThread() const;
 
   scoped_refptr<base::MessageLoopProxy> file_message_loop_;
   scoped_refptr<base::MessageLoopProxy> io_message_loop_;
 
   scoped_refptr<quota::QuotaManagerProxy> quota_manager_proxy_;
 
   // Mount point providers.
   scoped_ptr<SandboxMountPointProvider> sandbox_provider_;
   scoped_ptr<ExternalFileSystemMountPointProvider> external_provider_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(FileSystemContext);
 };
 
 struct DefaultContextDeleter {
   static void Destruct(const FileSystemContext* context) {
     context->DeleteOnCorrectThread();
   }
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_