Cleanup FileSystemOperation for preparing for adding FSO-factory method

webkit/fileapi/file_system_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/platform_file.h"

[ericu, 2012/01/09 18:44:44]

Why include platform_file.h?

[kinuko, 2012/01/10 09:48:53]

Removed.

 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/quota/special_storage_policy.h"
 
 class FilePath;
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace quota {
 class QuotaManagerProxy;
 }
 
 namespace fileapi {
 
 class ExternalFileSystemMountPointProvider;
+class FileSystemCallbackDispatcher;
 class FileSystemContext;
 class FileSystemFileUtil;
 class FileSystemMountPointProvider;
 class FileSystemOptions;
 class FileSystemPathManager;
 class FileSystemQuotaUtil;
 class SandboxMountPointProvider;
 
 struct DefaultContextDeleter;
 
@@ skipping 40 matching lines @@
   // Returns a FileSystemMountPointProvider instance for sandboxed filesystem
   // types (e.g. TEMPORARY or PERSISTENT).  This is equivalent to calling
   // GetMountPointProvider(kFileSystemType{Temporary, Persistent}).
   SandboxMountPointProvider* sandbox_provider() const;
 
   // Returns a FileSystemMountPointProvider instance for external filesystem
   // type, which is used only by chromeos for now.  This is equivalent to
   // calling GetMountPointProvider(kFileSystemTypeExternal).
   ExternalFileSystemMountPointProvider* external_provider() const;
 
+  // Opens the filesystem for the given |origin_url| and |type|, and dispatches
+  // the DidOpenFileSystem callback of the given |dispatcher|.
+  // If |create| is true this may actually setup a filesystem instance

[ericu, 2012/01/09 18:44:44]

s/setup/set up/

[kinuko, 2012/01/10 09:48:53]

Done.

+  // (e.g. by creating the root directory or initializing the database
+  // entry etc).
+  // TODO(kinuko): replace the dispatcher with a regular callback.
+  void OpenFileSystem(
+      const GURL& origin_url,
+      FileSystemType type,
+      bool create,
+      scoped_ptr<FileSystemCallbackDispatcher> dispatcher);
+
  private:
   friend struct DefaultContextDeleter;
   void DeleteOnCorrectThread() const;
 
   scoped_refptr<base::MessageLoopProxy> file_message_loop_;
   scoped_refptr<base::MessageLoopProxy> io_message_loop_;
 
   scoped_refptr<quota::QuotaManagerProxy> quota_manager_proxy_;
 
   // Mount point providers.
   scoped_ptr<SandboxMountPointProvider> sandbox_provider_;
   scoped_ptr<ExternalFileSystemMountPointProvider> external_provider_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(FileSystemContext);
 };
 
 struct DefaultContextDeleter {
   static void Destruct(const FileSystemContext* context) {
     context->DeleteOnCorrectThread();
   }
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_CONTEXT_H_