Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 9016010: Implement pref_value_map swap function. (Closed)

Created:
9 years ago by pastarmovj
Modified:
9 years ago
Reviewers:
battre
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implement pref_value_map swap function. Allows to swap the internal buffers for two pref_value_maps. BUG=chromium-os:19960 TEST=unit_tests:PrefValueMapTest.SwapTwoMaps Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/prefs/pref_value_map.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_value_map.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_value_map_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pastarmovj
Can you please review this tiny CL. Thanks!
9 years ago (2011-12-21 14:06:05 UTC) #1
battre
lgtm
9 years ago (2011-12-21 14:11:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9016010/1
9 years ago (2011-12-21 14:15:34 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-21 17:53:20 UTC) #4
Change committed as 115356

Powered by Google App Engine
This is Rietveld 408576698