Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 9015023: Undo allocation of half-formed array during elements transition (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 1278 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 __ mov(ecx, Operand(esp, last_arg_offset - kPointerSize)); 1290 __ mov(ecx, Operand(esp, last_arg_offset - kPointerSize));
1291 __ pop(eax); 1291 __ pop(eax);
1292 __ pop(ebx); 1292 __ pop(ebx);
1293 __ lea(esp, Operand(esp, ebx, times_pointer_size, 1293 __ lea(esp, Operand(esp, ebx, times_pointer_size,
1294 last_arg_offset - kPointerSize)); 1294 last_arg_offset - kPointerSize));
1295 __ jmp(ecx); 1295 __ jmp(ecx);
1296 1296
1297 __ bind(&has_non_smi_element); 1297 __ bind(&has_non_smi_element);
1298 // Throw away the array that's only been partially constructed. 1298 // Throw away the array that's only been partially constructed.
1299 __ pop(eax); 1299 __ pop(eax);
1300 __ UndoAllocationInNewSpace(eax);
1300 1301
1301 // Restore argc and constructor before running the generic code. 1302 // Restore argc and constructor before running the generic code.
1302 __ bind(&prepare_generic_code_call); 1303 __ bind(&prepare_generic_code_call);
1303 __ pop(eax); 1304 __ pop(eax);
1304 if (construct_call) { 1305 if (construct_call) {
1305 __ pop(edi); 1306 __ pop(edi);
1306 } 1307 }
1307 __ jmp(call_generic_code); 1308 __ jmp(call_generic_code);
1308 } 1309 }
1309 1310
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1723 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR); 1724 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR);
1724 generator.Generate(); 1725 generator.Generate();
1725 } 1726 }
1726 1727
1727 1728
1728 #undef __ 1729 #undef __
1729 } 1730 }
1730 } // namespace v8::internal 1731 } // namespace v8::internal
1731 1732
1732 #endif // V8_TARGET_ARCH_IA32 1733 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698