Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9015021: Remove DeleteTask and convert remaining users. (Closed)

Created:
8 years, 11 months ago by dcheng
Modified:
8 years, 11 months ago
Reviewers:
awong, Jói
CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, kkania, mihaip+watch_chromium.org, dhollowa+watch_chromium.org, ncarter (slow), acolwell+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ihf+watch_chromium.org, jstritar+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, scherkus (not reviewing), michaeln, hclam+watch_chromium.org, akalin, Aaron Boodman, eroman, robertshield, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

Remove DeleteTask and convert remaining users. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116107

Patch Set 1 #

Patch Set 2 : Compile fixes #

Patch Set 3 : Fix last Linux gotchas? #

Patch Set 4 : Fix last Linux gotchas (upload attempt #2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -92 lines) Patch
M base/task.h View 1 chunk +1 line, -20 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/protector/protector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/chrome_blob_storage_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_manager_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/host_zoom_map.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/download_manager.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
And that's all for DeleteTask!
8 years, 11 months ago (2011-12-30 17:30:10 UTC) #1
Jói
8 years, 11 months ago (2012-01-02 10:32:18 UTC) #2 
LGTM (looked at all files, not just content/public).

Powered by Google App Engine
This is Rietveld 408576698