Chromium Code Reviews| Index: media/base/media_log.cc |
| diff --git a/media/base/media_log.cc b/media/base/media_log.cc |
| index ea61682a7bbd530b95825b10d16dbd53a7b517d4..43b6f7ce5fa0e9c0706763b14e50cee51b4c4819 100644 |
| --- a/media/base/media_log.cc |
| +++ b/media/base/media_log.cc |
| @@ -150,81 +150,82 @@ MediaLog::MediaLog() { |
| MediaLog::~MediaLog() {} |
| -void MediaLog::AddEvent(MediaLogEvent* event) { |
| - scoped_ptr<MediaLogEvent> e(event); |
| +void MediaLog::AddEvent(scoped_ptr<MediaLogEvent> event) { |
| } |
| -MediaLogEvent* MediaLog::CreateEvent(MediaLogEvent::Type type) { |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateEvent(MediaLogEvent::Type type) { |
| scoped_ptr<MediaLogEvent> event(new MediaLogEvent); |
| event->id = id_; |
| event->type = type; |
| event->time = base::Time::Now(); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateBooleanEvent(MediaLogEvent::Type type, |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateBooleanEvent(MediaLogEvent::Type type, |
| const char* property, bool value) { |
|
scherkus (not reviewing)
2012/01/10 02:11:30
indent here + below
Ami GONE FROM CHROMIUM
2012/01/10 03:26:00
Done.
|
| scoped_ptr<MediaLogEvent> event(CreateEvent(type)); |
| event->params.SetBoolean(property, value); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateIntegerEvent(MediaLogEvent::Type type, |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateIntegerEvent(MediaLogEvent::Type type, |
| const char* property, int64 value) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(type)); |
| event->params.SetInteger(property, value); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateTimeEvent(MediaLogEvent::Type type, |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateTimeEvent(MediaLogEvent::Type type, |
| const char* property, |
| base::TimeDelta value) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(type)); |
| event->params.SetDouble(property, value.InSecondsF()); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateLoadEvent(const std::string& url) { |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateLoadEvent(const std::string& url) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::LOAD)); |
| event->params.SetString("url", url); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateSeekEvent(float seconds) { |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateSeekEvent(float seconds) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::SEEK)); |
| event->params.SetDouble("seek_target", seconds); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreatePipelineStateChangedEvent( |
| +scoped_ptr<MediaLogEvent> MediaLog::CreatePipelineStateChangedEvent( |
| PipelineImpl::State state) { |
| scoped_ptr<MediaLogEvent> event( |
| CreateEvent(MediaLogEvent::PIPELINE_STATE_CHANGED)); |
| event->params.SetString("pipeline_state", PipelineStateToString(state)); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreatePipelineErrorEvent(PipelineStatus error) { |
| +scoped_ptr<MediaLogEvent> MediaLog::CreatePipelineErrorEvent( |
| + PipelineStatus error) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PIPELINE_ERROR)); |
| event->params.SetString("pipeline_error", PipelineStatusToString(error)); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateVideoSizeSetEvent(size_t width, size_t height) { |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateVideoSizeSetEvent( |
| + size_t width, size_t height) { |
| scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::VIDEO_SIZE_SET)); |
| event->params.SetInteger("width", width); |
| event->params.SetInteger("height", height); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| -MediaLogEvent* MediaLog::CreateBufferedExtentsChangedEvent( |
| +scoped_ptr<MediaLogEvent> MediaLog::CreateBufferedExtentsChangedEvent( |
| size_t start, size_t current, size_t end) { |
| scoped_ptr<MediaLogEvent> event( |
| CreateEvent(MediaLogEvent::BUFFERED_EXTENTS_CHANGED)); |
| event->params.SetInteger("buffer_start", start); |
| event->params.SetInteger("buffer_current", current); |
| event->params.SetInteger("buffer_end", end); |
| - return event.release(); |
| + return event.Pass(); |
| } |
| void MediaLog::QueueStatisticsUpdatedEvent(PipelineStatistics stats) { |
| @@ -255,7 +256,7 @@ void MediaLog::AddStatisticsUpdatedEvent() { |
| last_statistics_.video_frames_decoded); |
| event->params.SetInteger("video_frames_dropped", |
| last_statistics_.video_frames_dropped); |
| - AddEvent(event.release()); |
| + AddEvent(event.Pass()); |
| stats_update_pending_ = false; |
| } |