Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 9015015: Take advantage of the new Pass() machinery on scoped_ptr{,_malloc}. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the dependency on CL 8968032 and point TODOs at the newly-filed bug. Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.cc
diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc
index 64fad537ae5a3f77b95919f37fcda0351c1fcc3b..7f69d4a3f2088bc564983b5ddae39dfde68ae9fa 100644
--- a/media/filters/chunk_demuxer.cc
+++ b/media/filters/chunk_demuxer.cc
@@ -56,7 +56,9 @@ static const uint8 kEmptyCluster[] = {
};
// Create an "end of stream" buffer.
-static Buffer* CreateEOSBuffer() { return new DataBuffer(0, 0); }
+static Buffer* CreateEOSBuffer() {
+ return new DataBuffer(scoped_array<uint8>(0), 0);
acolwell GONE FROM CHROMIUM 2012/01/03 22:46:40 nit: 0 not necessary in constructor.
Ami GONE FROM CHROMIUM 2012/01/03 22:52:02 Actually, scoped_array<uint8>(0) is not necessary.
+}
class ChunkDemuxerStream : public DemuxerStream {
public:

Powered by Google App Engine
This is Rietveld 408576698