Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: webkit/media/buffered_resource_loader.cc

Issue 9015015: Take advantage of the new Pass() machinery on scoped_ptr{,_malloc}. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased & removed unnecessary include of ffmpeg_common.h from ffmpeg_demuxer.h Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/buffered_resource_loader.cc
diff --git a/webkit/media/buffered_resource_loader.cc b/webkit/media/buffered_resource_loader.cc
index b1a40033f2ba95318ce7a7a8fedf5d139d867a5f..ace4e80bd5b644baacea6e5fa07ab452c8141202 100644
--- a/webkit/media/buffered_resource_loader.cc
+++ b/webkit/media/buffered_resource_loader.cc
@@ -182,7 +182,7 @@ void BufferedResourceLoader::Start(
// Start the resource loading.
loader->loadAsynchronously(request, this);
- active_loader_.reset(new ActiveLoader(loader));
+ active_loader_.reset(new ActiveLoader(scoped_ptr<WebURLLoader>(loader)));
acolwell GONE FROM CHROMIUM 2012/01/03 19:27:06 Perhaps make loader scoped_ptr since we've got own
Ami GONE FROM CHROMIUM 2012/01/03 20:58:34 Done.
}
void BufferedResourceLoader::Stop() {
@@ -317,8 +317,9 @@ const GURL& BufferedResourceLoader::url() {
return url_;
}
-void BufferedResourceLoader::SetURLLoaderForTest(WebURLLoader* test_loader) {
- test_loader_.reset(test_loader);
+void BufferedResourceLoader::SetURLLoaderForTest(
+ scoped_ptr<WebURLLoader> test_loader) {
+ test_loader_ = test_loader.Pass();
}
/////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698