Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 9015015: Take advantage of the new Pass() machinery on scoped_ptr{,_malloc}. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased & removed unnecessary include of ffmpeg_common.h from ffmpeg_demuxer.h Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/player_x11/player_x11.cc
diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc
index 3c1fa51a649d7b2e8193ffac20b76eabfc3835e6..c2da25fcabe25f6964e7b36dc6aac95a3c3b6c21 100644
--- a/media/tools/player_x11/player_x11.cc
+++ b/media/tools/player_x11/player_x11.cc
@@ -113,8 +113,9 @@ bool InitPipeline(MessageLoop* message_loop,
scoped_ptr<media::FilterCollection> collection(
new media::FilterCollection());
collection->SetDemuxerFactory(
- new media::FFmpegDemuxerFactory(
- new media::FileDataSourceFactory(), message_loop));
+ scoped_ptr<media::DemuxerFactory>(
+ new media::FFmpegDemuxerFactory(scoped_ptr<media::DataSourceFactory>(
+ new media::FileDataSourceFactory()), message_loop)));
collection->AddAudioDecoder(new media::FFmpegAudioDecoder(
message_loop_factory->GetMessageLoop("AudioDecoderThread")));
collection->AddVideoDecoder(new media::FFmpegVideoDecoder(
@@ -136,7 +137,7 @@ bool InitPipeline(MessageLoop* message_loop,
// Create the pipeline and start it.
*pipeline = new media::PipelineImpl(message_loop, new media::MediaLog());
media::PipelineStatusNotification note;
- (*pipeline)->Start(collection.release(), filename, note.Callback());
+ (*pipeline)->Start(collection.Pass(), filename, note.Callback());
// Wait until the pipeline is fully initialized.
note.Wait();

Powered by Google App Engine
This is Rietveld 408576698