| Index: media/base/composite_data_source_factory.cc
|
| diff --git a/media/base/composite_data_source_factory.cc b/media/base/composite_data_source_factory.cc
|
| index e75150593f2123f38e415f2d42d5051d399056f4..265ac833270df175eff833ff7ca42a8b4b36e4f4 100644
|
| --- a/media/base/composite_data_source_factory.cc
|
| +++ b/media/base/composite_data_source_factory.cc
|
| @@ -26,7 +26,7 @@ class CompositeDataSourceFactory::BuildRequest
|
| void CallNextFactory();
|
| void OnBuildDone(PipelineStatus status, DataSource* data_source);
|
|
|
| - FactoryList factories_;
|
| + FactoryList factories_; // Not owned by this class.
|
| };
|
|
|
| CompositeDataSourceFactory::CompositeDataSourceFactory() {}
|
| @@ -35,21 +35,26 @@ CompositeDataSourceFactory::~CompositeDataSourceFactory() {
|
| STLDeleteElements(&factories_);
|
| }
|
|
|
| -void CompositeDataSourceFactory::AddFactory(DataSourceFactory* factory) {
|
| - DCHECK(factory);
|
| - factories_.push_back(factory);
|
| +void CompositeDataSourceFactory::AddFactory(
|
| + scoped_ptr<DataSourceFactory> factory) {
|
| + DCHECK(factory.get());
|
| + factories_.push_back(factory.release());
|
| }
|
|
|
| -DataSourceFactory* CompositeDataSourceFactory::Clone() const {
|
| - CompositeDataSourceFactory* new_factory = new CompositeDataSourceFactory();
|
| +scoped_ptr<DataSourceFactory> CompositeDataSourceFactory::Clone() const {
|
| + scoped_ptr<CompositeDataSourceFactory> new_factory(
|
| + new CompositeDataSourceFactory());
|
|
|
| for (FactoryList::const_iterator itr = factories_.begin();
|
| itr != factories_.end();
|
| ++itr) {
|
| - new_factory->AddFactory((*itr)->Clone());
|
| + new_factory->AddFactory((*itr)->Clone().Pass());
|
| }
|
|
|
| - return new_factory;
|
| + // TODO(fischman): hopefully the extra scoped_ptr<m::DSF>() will be
|
| + // unnecessary once http://codereview.chromium.org/8968032/ lands
|
| + // properly.
|
| + return scoped_ptr<DataSourceFactory>(new_factory.Pass());
|
| }
|
|
|
| bool CompositeDataSourceFactory::AllowRequests() const {
|
|
|