Use the new callback tracker and delete the old one

Use the new callback tracker and delete the old one

I added some ClearAndRun and ClearAndAbort helper functions to clean up the
common pattern of doing a swap to run the callbacks. I was also able to clean
up some of the file callbacks stuff since the parameters to the new
TrackedCallback are simpler.

This fixes a scary bug in the Transport API where all completion callbacks
would be aborted for all objects when you close the connection (!)

The HostResourceTracker is no longer necessary since the only point of this
was to integrate with the callback tracker. I removed it.

BUG=74062
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116395

[viettrungluu, 2012-01-03 22:10:14]

LGTM w/1.25 nits.

http://codereview.chromium.org/9015009/diff/2001/ppapi/shared_impl/tracked_ca...
File ppapi/shared_impl/tracked_callback.h (right):

http://codereview.chromium.org/9015009/diff/2001/ppapi/shared_impl/tracked_ca...
ppapi/shared_impl/tracked_callback.h:90: // Same as RunAndClear except it calls
Abort().
ClearAndRun, not RunAndClear.

http://codereview.chromium.org/9015009/diff/2001/webkit/plugins/ppapi/ppb_tra...
File webkit/plugins/ppapi/ppb_transport_impl.cc (left):

http://codereview.chromium.org/9015009/diff/2001/webkit/plugins/ppapi/ppb_tra...
webkit/plugins/ppapi/ppb_transport_impl.cc:373:
plugin_module->GetCallbackTracker()->AbortAll();
Whoa, this was just wrong.

http://codereview.chromium.org/9015009/diff/2001/webkit/plugins/ppapi/ppb_tra...
File webkit/plugins/ppapi/ppb_transport_impl.cc (right):

http://codereview.chromium.org/9015009/diff/2001/webkit/plugins/ppapi/ppb_tra...
webkit/plugins/ppapi/ppb_transport_impl.cc:28: using ppapi::TrackedCallback;
Alphabetical order: discuss.

http://codereview.chromium.org/9015009/diff/2001/webkit/plugins/ppapi/ppb_tra...
webkit/plugins/ppapi/ppb_transport_impl.cc:247: if (started_)
Drive-by whinge: Apparently, you can call Connect() at most once (and not again,
even after Close()), since started_ is never reset.

(Side whinge: I'd also prefer "Disconnect" rather than "Close".)

[viettrungluu, 2012-01-03 23:51:27]

LGTM