Issue 9015002: Check for abstract method with body and top-level abstract elements, issue 871

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9015002: Check for abstract method with body and top-level abstract elements, issue 871 (Closed)

Created:
8 years, 11 months ago by scheglov

Modified:
8 years, 11 months ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check for abstract method with body and top-level abstract elements, issue 871 http://code.google.com/p/dart/issues/detail?id=871 R=codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2867

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -39 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	9 chunks	+35 lines, -5 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/parser/DartScanner.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	1 chunk	+29 lines, -25 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/IdeTests.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	3 chunks	+48 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

codefu

8 years, 11 months ago (2011-12-29 16:03:05 UTC) #3

http://codereview.chromium.org/9015002/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/9015002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:282: if
(isTopLevelAbstract) {
Couldn't this just be:
if(isTopLevelAbstract && !isParsingClass) {
  Error
}

Expand Messages | Collapse Messages